All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	"Chen, Tim C" <tim.c.chen@intel.com>,
	Rik van Riel <riel@redhat.com>,
	alex.shi@intel.com
Subject: Re: too big min_free_kbytes
Date: Tue, 22 Feb 2011 14:25:59 +0000	[thread overview]
Message-ID: <20110222142559.GD15652@csn.ul.ie> (raw)
In-Reply-To: <20110214022524.GA18198@sli10-conroe.sh.intel.com>

On Mon, Feb 14, 2011 at 10:25:24AM +0800, Shaohua Li wrote:
> On Thu, Feb 03, 2011 at 10:58:08AM +0800, Andrea Arcangeli wrote:
> > On Thu, Jan 27, 2011 at 04:27:55PM +0100, Andrea Arcangeli wrote:
> > > totally untested... I will test....
> > 
> > The below patch is fixing my problem and working fine for me... as
> > expected it can't possibly lead to any D state, it's pretty much like
> > setting min_free_kbytes lower, and it's not going to alter anything
> > other than the levels of free memory kept by kswapd.
> > 
> > $ while :; do ps xa|grep [k]swapd; sleep 1; done
> >   452 ?        R      1:20 [kswapd0]
> >   452 ?        S      1:20 [kswapd0]
> >   452 ?        S      1:20 [kswapd0]
> >   452 ?        S      1:20 [kswapd0]
> >   452 ?        S      1:20 [kswapd0]
> >   452 ?        R      1:20 [kswapd0]
> >   452 ?        R      1:20 [kswapd0]
> >   452 ?        R      1:20 [kswapd0]
> >   452 ?        R      1:20 [kswapd0]
> >   452 ?        S      1:20 [kswapd0]
> >   452 ?        R      1:20 [kswapd0]
> > $ vmstat 1
> > procs -----------memory---------- ---swap-- -----io---- -system--
> >   ----cpu----
> >  r  b   swpd   free   buff  cache   si   so    bi    bo   in   cs us
> >   sy id wa
> >  2  1   1784 111040 2393336 807924    0    0    63   992   56   70  1   1 96  2
> >  0  1   1784 108928 2402556 801864    0    0 122624     0 1619 2150  0   5 80 16
> >  0  1   1784 110664 2401244 801140    0    0 122496     0 1602 2081  0   3 81 16
> >  0  1   1784 109796 2410184 792984    0    0 122752     0 1685 2149  0   4 80 16
> >  0  1   1784 110416 2411856 791208    0    0 120448     4 1599 2075  0   4 81 16
> >  1  0   1784 113516 2415344 785336    0    0 122496     0 1636 2125  0   4 81 15
> > 
> > I doubt we'll get any regression because of the below (see also my
> > prev email in this thread), and I would only expect more cache and
> > maybe better lru. Previously the free memory levels were stuck at
> > ~700M now they're stuck at the right level for a 4G system with THP on
> > (I'd still like to try to reduce the requirements only 1 hugepage for
> > each migratetype in the set_min_free_kbytes to reduce the requirements
> > to the minium, but only if possible..). But this saves 600M over 4G so
> > it's the highest prio to address.
> Sorry for the later response, I offlined several weeks.
> The patch is addressing the 8*high_wmark issue, which isn't the original issue
> I reported (sure the 8*wmark issue should be fixed too).
> min_free_kbytes is set higher and cause more pages freed even no the 8*wmark
> issue. wmark:
> before: min      1424
> after:	min      11178

The higher min_free_kbytes is expected as a result of using transparent
hugepages so I don't really consider it a bug. Free memory going up to
about 700M as a result of kswapd is a real bug though.

> in our test, there is about 50M memory free (originally just about 5M, which
> will cause more swap. Should we also reduce the min_free_kbytes?
> 

Either that or boot with transparent hugepages disabled and
min_free_kbytes will be lower.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-02-22 14:26 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24  3:56 too big min_free_kbytes Shaohua Li
2011-01-24 15:00 ` Andrea Arcangeli
2011-01-25 14:35   ` Mel Gorman
2011-01-26 14:17   ` Mel Gorman
2011-01-26 15:23     ` Mel Gorman
2011-01-26 15:42       ` Andrea Arcangeli
2011-01-26 16:36         ` Mel Gorman
2011-01-26 17:42           ` Mel Gorman
2011-01-27 13:40             ` Mel Gorman
2011-01-27 15:27               ` Andrea Arcangeli
2011-01-27 16:03                 ` Mel Gorman
2011-01-27 18:52                   ` Andrea Arcangeli
2011-01-27 20:33                     ` Rik van Riel
2011-01-27 21:31                     ` Mel Gorman
2011-01-27 23:18                       ` Rik van Riel
2011-01-28 10:35                         ` Mel Gorman
2011-01-28 16:28                           ` Andrea Arcangeli
2011-01-28 16:46                             ` Mel Gorman
2011-01-28 17:16                               ` Rik van Riel
2011-01-28 17:46                                 ` Andrea Arcangeli
2011-01-28 18:03                                   ` Rik van Riel
2011-01-28 18:24                                     ` Andrea Arcangeli
2011-01-28 19:34                                       ` Rik van Riel
2011-01-28 19:45                                         ` Andrea Arcangeli
2011-01-28 20:55                                           ` Rik van Riel
2011-01-29 19:45                                             ` Andrea Arcangeli
2011-01-28 17:34                               ` Andrea Arcangeli
2011-01-28 17:10                             ` Rik van Riel
2011-02-03  2:58                 ` Andrea Arcangeli
2011-02-03 13:15                   ` Mel Gorman
2011-02-03 18:59                     ` Andrea Arcangeli
2011-02-03 14:36                   ` Rik van Riel
2011-02-03 19:11                     ` Andrea Arcangeli
2011-02-12  1:28                       ` Simon Kirby
2011-02-14  2:25                   ` Shaohua Li
2011-02-22 14:25                     ` Mel Gorman [this message]
2011-02-22 14:42                       ` Andrea Arcangeli
2011-02-22 14:50                         ` Mel Gorman
2011-02-22 14:54                           ` Andrea Arcangeli
2011-02-22 16:04                         ` Mel Gorman
2011-02-22 16:40                           ` Rik van Riel
2011-02-23  5:29                       ` Shaohua Li
2011-02-23 14:45                         ` Andrea Arcangeli
2011-02-24  8:08                           ` Shaohua Li
2011-02-24  9:52                             ` Mel Gorman
2011-02-24  9:57                               ` Mel Gorman
2011-02-24 14:27                                 ` Andrea Arcangeli
2011-02-24 14:04                             ` Andrea Arcangeli
2011-02-25  0:51                               ` Shaohua Li
2011-02-25 12:13                                 ` Mel Gorman
2011-02-12  9:48                 ` alex shi
2011-02-22 14:24                   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110222142559.GD15652@csn.ul.ie \
    --to=mel@csn.ul.ie \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=shaohua.li@intel.com \
    --cc=tim.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.