From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] Add support for pcsuite lock file
Date: Tue, 22 Feb 2011 16:14:20 -0300 [thread overview]
Message-ID: <20110222191419.GA5469@jh-x301> (raw)
In-Reply-To: <1298367822-27766-1-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Tue, Feb 22, 2011, Luiz Augusto von Dentz wrote:
> This should make others applications able to detect when pcsuite is
> connected.
> ---
> plugins/ftp.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 154 insertions(+), 6 deletions(-)
Doesn't compile (ssize_t correct format string is %zd):
plugins/ftp.c: In function 'ftp_put':
plugins/ftp.c:288: error: format '%d' expects type 'int', but argument 6 has type 'ssize_t'
Also, all the added debug prints don't seem to relate to the commit
message in anyway. Probably better to split into a separate patch?
Johan
next prev parent reply other threads:[~2011-02-22 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 9:43 [PATCH 1/5] Add support for pcsuite lock file Luiz Augusto von Dentz
2011-02-22 9:43 ` [PATCH 2/5] Add flush callback to mimetype driver Luiz Augusto von Dentz
2011-02-22 9:43 ` [PATCH 3/5] Add .flush callback to backup plugin Luiz Augusto von Dentz
2011-02-22 9:43 ` [PATCH 4/5] Move pcsuite drivers to its own plugin Luiz Augusto von Dentz
2011-02-22 9:43 ` [PATCH 5/5] Fix --enable-usb build Luiz Augusto von Dentz
2011-02-22 14:05 ` Vinicius Costa Gomes
2011-02-22 14:13 ` Luiz Augusto von Dentz
2011-02-22 19:14 ` Johan Hedberg [this message]
2011-02-22 20:23 ` [PATCH 1/5] Add support for pcsuite lock file Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222191419.GA5469@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.