From: Dan Carpenter <error27@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Kees Cook <kees.cook@canonical.com>,
linux-kernel@vger.kernel.org, Eugene Teo <eugeneteo@kernel.sg>,
Ralph Campbell <infinipath@qlogic.com>,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
"J. Bruce Fields" <bfields@fieldses.org>,
Neil Brown <neilb@suse.de>, Matthew Wilcox <matthew@wil.cx>,
James Morris <jmorris@namei.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
Nick Piggin <npiggin@kernel.dk>, Arnd Bergmann <arnd@arndb.de>,
Ian Campbell <ian.campbell@citrix.com>,
Jarkko Sakkinen <ext-jarkko.2.sakkinen@nokia.com>,
Tejun Heo <tj@kernel.org>,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH 2/2] debugfs: only allow root access to debugging interfaces
Date: Tue, 22 Feb 2011 23:29:15 +0300 [thread overview]
Message-ID: <20110222202915.GC1966@bicker> (raw)
In-Reply-To: <20110222193314.GA11033@suse.de>
On Tue, Feb 22, 2011 at 11:33:14AM -0800, Greg KH wrote:
> Again, let's fix the real problems here, world-writable debugfs files.
We could just ban them?
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index e7a7a2f..03ae095 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -223,6 +223,9 @@ struct dentry *debugfs_create_file(const char *name, mode_t mode,
pr_debug("debugfs: creating file '%s'\n",name);
+ /* don't allow world writable files */
+ mode &= ~S_IWOTH;
+
error = simple_pin_fs(&debug_fs_type, &debugfs_mount,
&debugfs_mount_count);
if (error)
next prev parent reply other threads:[~2011-02-22 20:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 18:09 [PATCH 1/2] fs: pass root inode mode to simple_fill_super Kees Cook
2011-02-22 18:09 ` [PATCH 2/2] debugfs: only allow root access to debugging interfaces Kees Cook
2011-02-22 18:16 ` Kees Cook
2011-02-22 18:32 ` David Daney
2011-02-22 18:47 ` Kees Cook
2011-02-22 19:14 ` Greg KH
2011-02-22 19:25 ` Kees Cook
2011-02-22 19:34 ` Alan Cox
2011-02-22 19:50 ` Kees Cook
2011-02-22 19:53 ` David Daney
2011-02-22 20:16 ` Greg KH
2011-02-22 20:28 ` Kees Cook
2011-02-22 20:37 ` Greg KH
2011-02-22 20:54 ` Kees Cook
2011-02-25 0:22 ` Kees Cook
2011-02-25 0:35 ` Greg KH
2011-02-25 1:12 ` Kees Cook
2011-02-25 3:31 ` Greg KH
2011-02-25 3:39 ` Al Viro
2011-02-22 19:54 ` Kees Cook
2011-02-22 19:43 ` Greg KH
2011-02-22 19:13 ` Greg KH
2011-02-22 19:22 ` Kees Cook
2011-02-22 19:33 ` Greg KH
2011-02-22 20:29 ` Dan Carpenter [this message]
2011-02-22 20:33 ` Kees Cook
2011-02-22 20:58 ` Henrique de Moraes Holschuh
2011-02-24 16:38 ` Steven Rostedt
2011-02-24 17:34 ` Henrique de Moraes Holschuh
2011-02-26 11:50 ` Arnd Bergmann
2011-02-25 19:56 ` Greg KH
2011-02-25 20:40 ` Hugh Dickins
2011-02-25 20:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222202915.GC1966@bicker \
--to=error27@gmail.com \
--cc=arnd@arndb.de \
--cc=bfields@fieldses.org \
--cc=casey@schaufler-ca.com \
--cc=eparis@parisplace.org \
--cc=eugeneteo@kernel.sg \
--cc=ext-jarkko.2.sakkinen@nokia.com \
--cc=gregkh@suse.de \
--cc=hal.rosenstock@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=infinipath@qlogic.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=npiggin@kernel.dk \
--cc=roland@kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=sean.hefty@intel.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.