[Ocfs2-devel] [PATCH] Treat writes as new when holes span across page boundaries

[Joel Becker <jlbec@evilplan.org>]

On Tue, Feb 22, 2011 at 01:02:13PM -0600, Goldwyn Rodrigues wrote:
> On Tue, Feb 22, 2011 at 2:36 AM, Joel Becker <jlbec@evilplan.org> wrote:
> > ? ? ? ?Please try the attached patch and see if it fixes the problem.
> > It should work on its own, without your changes. ?If I have it wrong,
> > we'll continue to evaluate the problem. ?I'd test it myself, but my VM
> > setup is currently broken.
> >
> 
> It does not work. However, it shows the behavior similar to "nosparse"
> without patch. So, I would say what you are targeting is achieved but
> another problem resurfaces. This is because nothing zeros pages beyond
> i_size in ocfs2_map_page_blocks(), since we return early because of -
> 
>         if (ret == 0 || !new)
>                 return ret;

	Returning here is correct, because ret should == 0.  The new
part is about zeroing in the case of error.  We should obviously handle
it better before we get to this line.
	I like that we come in line nosparse and sparse.  What does
tailtest do for you?  Does it fail or succeed?

Joel

-- 

"Here's a nickle -- get yourself a better X server."
	- Keith Packard

			http://www.jlbec.org/
			jlbec at evilplan.org