From: Dan Carpenter <error27@gmail.com>
To: Martyn Welch <martyn.welch@ge.com>
Cc: Manohar Vanga <manohar.vanga@cern.ch>,
devel@driverdev.osuosl.org, gregkh@suse.de, cota@braap.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vme: fix bug in vme_register_bridge
Date: Wed, 23 Feb 2011 15:24:43 +0300 [thread overview]
Message-ID: <20110223122443.GS1898@bicker> (raw)
In-Reply-To: <4D64D70A.1060007@ge.com>
On Wed, Feb 23, 2011 at 09:44:42AM +0000, Martyn Welch wrote:
> On 23/02/11 09:26, Manohar Vanga wrote:
> > Fix a bug in vme_register_bridge that results in an infinite loop in
> > the event that device_register fails.
[snip]
> > + /*
> > + * Ignore the failed device and unregister the rest.
> > + */
> > + i--;
> > while (i > -1) {
> > dev = &bridge->dev[i];
> > device_unregister(dev);
> > + i--;
> > }
Ah. I see you fixed the bug already. Good deal. Btw, no need to add
comments for the obvious stuff.
You still aren't CCing the right list, devel@driverdev.osuosl.org.
It's not enough for Martyn to sent it to us, because by that point
the patch has '> ' chars on every line.
regards,
dan carpenter
prev parent reply other threads:[~2011-02-23 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1298453209-30821-1-git-send-email-manohar.vanga@cern.ch>
2011-02-23 9:44 ` [PATCH 2/2] staging: vme: fix bug in vme_register_bridge Martyn Welch
2011-02-23 12:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223122443.GS1898@bicker \
--to=error27@gmail.com \
--cc=cota@braap.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@cern.ch \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.