Re: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirq to kthread

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Wed, Feb 23, 2011 at 04:09:43AM +0100, Frederic Weisbecker wrote:
> On Tue, Feb 22, 2011 at 05:39:40PM -0800, Paul E. McKenney wrote:
> > +/*
> > + * Set the per-rcu_node kthread's affinity to cover all CPUs that are
> > + * served by the rcu_node in question.
> > + */
> > +static void rcu_node_kthread_setaffinity(struct rcu_node *rnp)
> > +{
> > +	cpumask_var_t cm;
> > +	int cpu;
> > +	unsigned long mask = rnp->qsmaskinit;
> > +
> > +	if (rnp->node_kthread_task == NULL ||
> > +	    rnp->qsmaskinit == 0)
> > +		return;
> > +	if (!alloc_cpumask_var(&cm, GFP_KERNEL))
> > +		return;
> > +	cpumask_clear(cm);
> > +	for (cpu = rnp->grplo; cpu <= rnp->grphi; cpu++, mask <<= 1)
> 
> There seem to be the same shift problem here.

Right you are, thank you again!!!

							Thanx, Paul

> > +		if (mask & 01)
> > +			cpumask_set_cpu(cpu, cm);
> > +	set_cpus_allowed_ptr(rnp->node_kthread_task, cm);
> > +	free_cpumask_var(cm);
> > +}