From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Adjust mineln with discard_granularity in FITRIM code
Date: Wed, 23 Feb 2011 12:58:35 -0500 [thread overview]
Message-ID: <20110223175835.GO2924@thunk.org> (raw)
In-Reply-To: <1297789585-5986-2-git-send-email-lczerner@redhat.com>
On Tue, Feb 15, 2011 at 06:06:25PM +0100, Lukas Czerner wrote:
> Discard granularity tells us the minimum size of extent to be discarded.
> Use that information to adjust minlen properly in FITRIM code. Smaller
> extents will be ignored anyway, so we can optimize by not even trying to
> discard them.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Applied to the ext4 patch queue, with a rewritten commit description.
"Always write with a deep sympathy for the reader"
- Ted
ext4: Adjust minlen with discard_granularity in the FITRIM ioctl
From: Lukas Czerner <lczerner@redhat.com>
Discard granularity tells us the minimum size of extent that can be
discard by the device. If the user supplies a minimum extent that
should be discarded (range.minlen) which is smaller than the discard
granularity, increase minlen to the discard granularity, since there's
no point submitting trim requests that the device will reject anyway.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
next prev parent reply other threads:[~2011-02-23 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 17:06 [PATCH 1/2] ext4: check if device support discard in FITRIM ioctl Lukas Czerner
2011-02-15 17:06 ` [PATCH 2/2] ext4: Adjust mineln with discard_granularity in FITRIM code Lukas Czerner
2011-02-23 17:58 ` Ted Ts'o [this message]
2011-02-23 18:19 ` Lukas Czerner
2011-02-23 17:50 ` [PATCH 1/2] ext4: check if device support discard in FITRIM ioctl Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223175835.GO2924@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.