From: Greg KH <greg@kroah.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>,
"Abhishek Kane (Mindtree Consulting PVT LTD)"
<v-abkane@microsoft.com>, "gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>
Subject: Re: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order
Date: Wed, 23 Feb 2011 15:06:54 -0800 [thread overview]
Message-ID: <20110223230654.GA18829@kroah.com> (raw)
In-Reply-To: <A1F3067C9B68744AA19F6802BAB8FFDC060EE9@TK5EX14MBXC227.redmond.corp.microsoft.com>
On Wed, Feb 23, 2011 at 10:55:12PM +0000, Haiyang Zhang wrote:
> > From: Greg KH [mailto:greg@kroah.com]
> > The layering is almost ok, there is still one more layer here than is
> > needed, and it should be removed (I already removed lots of layers that
> > were not needed, just didn't get to this one.) But the naming also
> > needs to be fixed up as it is wrong from a "driver model" standpoint
> > with the rest of the kernel.
>
> So, how about rename the "struct driver_context" to "struct gen_drv_ctx"
> in this patch? We can deal with the layering in next round of patches.
No, it's not a "driver context" at all. It is a "hyperv driver", so
name it as such.
A "context" is a void pointer or something that the driver uses
privately. And you already have a pointer to the context in the base
structure so you don't need your own.
You should work on removing the layering now, that will clean this all
up.
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-23 23:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 20:19 [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order Haiyang Zhang
2011-02-23 20:19 ` [PATCH 2/4] staging: hv: Fix the code depending on struct netvsc_driver_context " Haiyang Zhang
2011-02-23 20:19 ` [PATCH 3/4] staging: hv: Fix the code depending on struct blkvsc_driver_context " Haiyang Zhang
2011-02-23 20:19 ` Haiyang Zhang
2011-02-23 20:19 ` [PATCH 4/4] staging: hv: Fix the code depending on struct storvsc_driver_context " Haiyang Zhang
2011-02-23 20:19 ` Haiyang Zhang
2011-02-23 21:28 ` Greg KH
2011-02-23 21:28 ` [PATCH 3/4] staging: hv: Fix the code depending on struct blkvsc_driver_context " Greg KH
2011-02-23 20:53 ` [PATCH 2/4] staging: hv: Fix the code depending on struct netvsc_driver_context " Thomas Gleixner
2011-02-23 20:53 ` Thomas Gleixner
2011-02-23 21:27 ` Greg KH
2011-02-23 20:19 ` Haiyang Zhang
2011-02-23 21:26 ` [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context " Greg KH
2011-02-23 22:44 ` KY Srinivasan
2011-02-23 22:48 ` Greg KH
2011-02-23 22:55 ` Haiyang Zhang
2011-02-23 23:06 ` Greg KH [this message]
2011-02-23 22:58 ` KY Srinivasan
2011-02-23 22:48 ` Haiyang Zhang
-- strict thread matches above, loose matches on Subject: below --
2011-02-23 20:19 Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223230654.GA18829@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v-abkane@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.