All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	"Gustavo F. Padovan" <padovan@profusion.mobi>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Jeff Chua <jeff.chua.linux@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: btusb autosuspend (was Re: Linux 2.6.38-rc6)
Date: Thu, 24 Feb 2011 00:43:33 +0000	[thread overview]
Message-ID: <20110224004333.GA22698@srcf.ucam.org> (raw)
In-Reply-To: <AANLkTimTzjHkVQGPBRXrcb6M1_xaDY_==pB5ZyB9CJpR@mail.gmail.com>

On Wed, Feb 23, 2011 at 04:25:23PM -0800, Linus Torvalds wrote:
> Hmm. Is there any reason we shouldn't revert commit
> 556ea928f78a390fe16ae584e6433dff304d3014 given the regression?

I think reverting makes sense at the moment. I haven't seen the reported 
issues - I need to figure out if this is related to bus powered/self 
powered devices, or what else is causing the difference.

> It apparently had problems before too, and caused autosuspend to be
> disabled entirely, judging at least by
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=528744
> 
> but there's obviously the comment about "those should be fixed now".
> Apparently there are more issues.

Right, we were autosuspending even when there were active connections. 
Marcel told me that ought to be fixed and my testing seemed to agree...

> I have no idea whether this is a USB-level issue, or a driver-level
> one. There are no comments about exactly what fixed the input device
> issues. So I'm adding both BT and USB people to the discussion.

I'll try to get time to look at this this week. Marcel, any ideas?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  parent reply	other threads:[~2011-02-24  0:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24  0:25 btusb autosuspend (was Re: Linux 2.6.38-rc6) Linus Torvalds
2011-02-24  0:40 ` Greg KH
2011-02-24  0:43 ` Matthew Garrett [this message]
2011-02-24 14:55   ` Alan Stern
2011-03-01 10:22   ` Oliver Neukum
2011-02-24  2:42 ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110224004333.GA22698@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=gregkh@suse.de \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=padovan@profusion.mobi \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.