From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3, 12/16] xfsprogs: metadump: no need for local copy of name when obfuscating
Date: Thu, 24 Feb 2011 13:04:55 +1100 [thread overview]
Message-ID: <20110224020455.GZ3166@dastard> (raw)
In-Reply-To: <201102182121.p1ILL23t029159@stout.americas.sgi.com>
On Fri, Feb 18, 2011 at 03:21:02PM -0600, Alex Elder wrote:
> The local "newname" buffer in obfuscate_name() is used to hold
> an obfuscated name as it gets generated. But it is always copied
> back into the passed-in name buffer, so we might as well just use
> the name buffer passed directly and avoid the copy.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-02-24 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:21 [PATCH v3, 12/16] xfsprogs: metadump: no need for local copy of name when obfuscating Alex Elder
2011-02-24 2:04 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224020455.GZ3166@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.