From: Ted Ts'o <tytso@mit.edu>
To: Coly Li <i@coly.li>
Cc: linux-ext4@vger.kernel.org, Alex Tomas <alex@clusterfs.com>,
Theodore Tso <tytso@google.com>
Subject: Re: [PATCH 4/5] mballoc: change comments to ac_g_ex
Date: Thu, 24 Feb 2011 14:08:22 -0500 [thread overview]
Message-ID: <20110224190822.GX2924@thunk.org> (raw)
In-Reply-To: <4D4E2970.8050709@coly.li>
On Sun, Feb 06, 2011 at 12:54:08PM +0800, Coly Li wrote:
> Current comments to ac_g_ex, the member of struct
> ext4_allocation_context is,
> /* goal request (after normalization) */
> This is a little bit confused. In order to make it easier to be
> understood, this patch modify the comments as,
> /* goal request (normalized ac_o_ex) */
> which means ac_g_ex is a normalized value of ac_o_ex.
>
> Signed-off-by: Coly Li <bosong.ly@taobao.com>
> Cc: Alex Tomas <alex@clusterfs.com>
> Cc: Theodore Tso <tytso@google.com>
Added to the ext4 patch queue, thanks.
I used a much simpler patch comment:
ext4: clarify description of ac_g_ex in struct ext4_allocation_context
Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Alex Tomas <alex@clusterfs.com>
Cc: Theodore Tso <tytso@google.com>
- Ted
prev parent reply other threads:[~2011-02-24 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 4:54 [PATCH 4/5] mballoc: change comments to ac_g_ex Coly Li
2011-02-24 19:08 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224190822.GX2924@thunk.org \
--to=tytso@mit.edu \
--cc=alex@clusterfs.com \
--cc=i@coly.li \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.