All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Philip Rakity <prakity@marvell.com>
Cc: "Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
	Jae hoon Chung <jh80.chung@gmail.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/1]mmc: set timeout for SDHCI host before sending busy cmd
Date: Thu, 24 Feb 2011 20:15:04 +0000	[thread overview]
Message-ID: <20110224201504.GA12913@void.printf.net> (raw)
In-Reply-To: <79DD18D4-C79A-4B08-B9E6-050D7EF2FC3D@marvell.com>

On Thu, Feb 24, 2011 at 10:32:30AM -0800, Philip Rakity wrote:
> proposed this a while ago and strongly support just removing the quirk for broken timeout and setting the timeout value to maximum of 0xE.
> 
> This also handles the case of the sd device having a timeout value too low.  In my testing I have come across SD cards that do not provide the correct value.
> We force our pxa168, pxa910, and mmp2 controllers to have 0xE.  

Yeah, OLPC's CaFe controller -- which might be the same hardware as yours,
actually -- has the same problem.

Does anyone know of a reason (beyond strict spec-compliance, I suppose)
for honoring the timeout value rather than using 0xE everywhere?  If not,
I'm willing to try out Philip's suggestion.

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-02-24 20:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 11:19 [PATCH 1/1]mmc: set timeout for SDHCI host before sending busy cmd Chuanxiao Dong
2011-02-24 14:18 ` Jae hoon Chung
2011-02-24 14:54   ` Dong, Chuanxiao
2011-02-24 18:32     ` Philip Rakity
2011-02-24 20:15       ` Chris Ball [this message]
2011-02-24 20:43         ` Wolfram Sang
2011-02-24 21:24           ` Chris Ball
2011-02-25  1:25         ` Philip Rakity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110224201504.GA12913@void.printf.net \
    --to=cjb@laptop.org \
    --cc=arnd@arndb.de \
    --cc=chuanxiao.dong@intel.com \
    --cc=jh80.chung@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.