From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/8] trace: add trace_vprintf
Date: Thu, 24 Feb 2011 15:08:36 -0600 [thread overview]
Message-ID: <20110224210836.GE17412@elie> (raw)
In-Reply-To: <20110224142814.GC15477@sigill.intra.peff.net>
Jeff King wrote:
> --- a/cache.h
> +++ b/cache.h
> @@ -1067,6 +1067,7 @@ extern void alloc_report(void);
> /* trace.c */
> __attribute__((format (printf, 1, 2)))
> extern void trace_printf(const char *format, ...);
> +extern void trace_vprintf(const char *format, va_list ap);
Micronit.
Though now that I think of it, the format(printf, n, 0) attribute
doesn't seem to be used anywhere in git currently. Is it unportable?
---
diff --git a/cache.h b/cache.h
index 08b23b2..288d4d0 100644
--- a/cache.h
+++ b/cache.h
@@ -1067,6 +1067,7 @@ extern void alloc_report(void);
/* trace.c */
__attribute__((format (printf, 1, 2)))
extern void trace_printf(const char *format, ...);
+__attribute__((format (printf, 1, 0)))
extern void trace_vprintf(const char *format, va_list ap);
__attribute__((format (printf, 2, 3)))
extern void trace_argv_printf(const char **argv, const char *format, ...);
next prev parent reply other threads:[~2011-02-24 21:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 14:23 [PATCH/RFC 0/8] refactor trace code Jeff King
2011-02-24 14:26 ` [RFC/PATCH 1/8] compat: provide a fallback va_copy definition Jeff King
2011-02-24 15:57 ` Erik Faye-Lund
2011-03-08 8:33 ` [PATCH jk/strbuf-vaddf] compat: fall back on __va_copy if available Jonathan Nieder
2011-03-08 20:09 ` Junio C Hamano
2011-03-08 20:59 ` Jonathan Nieder
2011-02-24 20:33 ` [RFC/PATCH 1/8] compat: provide a fallback va_copy definition Jonathan Nieder
2011-02-24 14:27 ` [PATCH 2/8] strbuf: add strbuf_addv Jeff King
2011-02-24 15:05 ` Christian Couder
2011-02-24 15:07 ` Jeff King
2011-02-24 20:51 ` Jonathan Nieder
2011-02-24 14:28 ` [PATCH 3/8] trace: add trace_vprintf Jeff King
2011-02-24 21:08 ` Jonathan Nieder [this message]
2011-02-24 14:28 ` [PATCH 4/8] trace: refactor to support multiple env variables Jeff King
2011-02-24 18:25 ` Junio C Hamano
2011-02-24 19:02 ` Jeff King
2011-02-24 19:44 ` Junio C Hamano
2011-02-24 19:48 ` Jeff King
2011-02-24 20:50 ` Junio C Hamano
2011-02-24 21:23 ` Jonathan Nieder
2011-02-24 14:28 ` [PATCH 5/8] trace: factor out "do we want to trace" logic Jeff King
2011-02-24 15:07 ` Christian Couder
2011-02-24 14:29 ` [PATCH 6/8] trace: add trace_strbuf Jeff King
2011-02-24 14:30 ` [PATCH 7/8] add packet tracing debug code Jeff King
2011-02-24 21:44 ` Jonathan Nieder
2011-02-24 14:30 ` [PATCH 8/8] trace: give repo_setup trace its own key Jeff King
2011-02-24 15:59 ` Andreas Ericsson
2011-02-24 16:05 ` Jeff King
2011-02-24 20:01 ` Christian Couder
2011-02-24 21:49 ` Jonathan Nieder
2011-02-25 6:38 ` Nguyen Thai Ngoc Duy
2011-02-26 8:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224210836.GE17412@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.