All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
	cjb@laptop.org, madhu.cr@ti.com, khilman@deeprootsystems.com,
	paul@pwsan.com, b-cousson@ti.com
Subject: Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework
Date: Thu, 24 Feb 2011 15:32:15 -0800	[thread overview]
Message-ID: <20110224233215.GX20560@atomide.com> (raw)
In-Reply-To: <1298575614-9388-6-git-send-email-kishore.kadiyala@ti.com>

* Kishore Kadiyala <kishore.kadiyala@ti.com> [110224 11:17]:
> Changes involves:
> 1) Remove controller reset in devices.c which is taken care of
>    by hwmod framework.
> 2) Omap2420 platform consists of mmc block as in omap1 and not the
>    hsmmc block as present in omap2430, omap3, omap4 platforms.
>    Removing all base address macro defines except keeping one for OMAP2420.
> 3) Using omap-device layer to register device and utilizing data from
>    hwmod data file for base address, dma channel number, Irq_number,
>    device attribute.
> 4) Update the driver to use dev_attr to find whether controller
>    supports dual volt cards

This patch is too hard to read. Can you please split it into 
more readable patches?

Thanks,

Tony

  reply	other threads:[~2011-02-24 23:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 19:26 [PATCH v4 0/6] OMAP: HSMMC: hwmod adaptation Kishore Kadiyala
2011-02-24 19:26 ` [PATCH v4 1/6] OMAP2430: hwmod data: Add HSMMC Kishore Kadiyala
2011-02-24 19:26 ` [PATCH v4 2/6] OMAP3: " Kishore Kadiyala
2011-02-24 19:26 ` [PATCH v4 3/6] OMAP4: hwmod data: enable HSMMC Kishore Kadiyala
2011-02-24 19:26 ` [PATCH v4 4/6] OMAP: hwmod data: Add dev_attr and use in the host driver Kishore Kadiyala
2011-02-25 13:15   ` Cousson, Benoit
2011-02-24 19:26 ` [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework Kishore Kadiyala
2011-02-24 23:32   ` Tony Lindgren [this message]
2011-02-25 17:03     ` Kadiyala, Kishore
2011-02-25 12:50   ` Krishnamoorthy, Balaji T
2011-02-25 13:28     ` Kadiyala, Kishore
2011-02-24 19:26 ` [PATCH v4 6/6] OMAP: hsmmc: Rename the device and driver Kishore Kadiyala
2011-02-25 13:20   ` Cousson, Benoit
2011-02-25 12:54 ` [PATCH v4 0/6] OMAP: HSMMC: hwmod adaptation Cousson, Benoit
2011-02-25 13:06   ` Kadiyala, Kishore
2011-02-25 13:12     ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110224233215.GX20560@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=cjb@laptop.org \
    --cc=khilman@deeprootsystems.com \
    --cc=kishore.kadiyala@ti.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.