From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from goalie.tycho.ncsc.mil (goalie [144.51.3.250]) by tarius.tycho.ncsc.mil (8.13.1/8.13.1) with ESMTP id p1P9urHt020241 for ; Fri, 25 Feb 2011 04:56:53 -0500 Received: from a.mx.secunet.com (localhost [127.0.0.1]) by msux-gh1-uea01.nsa.gov (8.12.10/8.12.10) with ESMTP id p1P9upit017658 for ; Fri, 25 Feb 2011 09:56:51 GMT Date: Fri, 25 Feb 2011 10:56:48 +0100 From: Steffen Klassert To: Eric Paris Cc: Paul Moore , James Morris , Eric Paris , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov Subject: Re: [PATCH 4/4 v2] selinux: xfrm - notify users on dropped packets Message-ID: <20110225095648.GA6653@secunet.com> References: <20110223115343.GH20852@secunet.com> <20110223115715.GL20852@secunet.com> <201102230956.53069.paul.moore@hp.com> <20110224082252.GP20852@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On Thu, Feb 24, 2011 at 09:51:04AM -0500, Eric Paris wrote: > All printk() statement require a KERN_*. I've often heard upstream > people say that every printk should only be printed if you expect the > user to do something with it. If it doesn't give the user enough > information to fix whatever the problem is, or know how to fix > whatever the problem is, it's a bad printk. I don't know this code at > all, but I'm pretty sure if I got those printk's I'd just feel > dumb.... > The problem with this patch is, that it was one of my debugging patches when I tried to find out why my packets are dropped. It was not contemplated to push it upstream when I wrote it. Then I thought it would be good to print out a message if these packets are dropped and I picked the patch from my debugging branch, which was a bad idea. I think we should drop this patch entirely and focus on the remaining 3 paches for now, as they are real fixes. So I could resend the remaining patches for another round of review, or does anybody want to thake them as they are? Steffen -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.