From: "John W. Linville" <linville@tuxdriver.com>
To: Joe Gunn <armadefuego@yahoo.com>
Cc: orinoco-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2.6.38-rc6-wl 1/1] orinoco: Drop scan results with unknown channels
Date: Fri, 25 Feb 2011 09:32:44 -0500 [thread overview]
Message-ID: <20110225143244.GA15897@tuxdriver.com> (raw)
In-Reply-To: <557082.85443.qm@web57406.mail.re1.yahoo.com>
On Fri, Feb 25, 2011 at 02:08:49AM -0800, Joe Gunn wrote:
> If the frequency can not be mapped to a channel structure log it and drop it.
FWIW, the Signed-off-by goes here. No need to repost, I'll fix it...
> ---
> The driver was getting an error return from the frequency map. The invalid freq
> uency was not in the frequency table, so the channel structure returned null. T
> his test fro that case and does not allow the packet to continue up the stack.
> ---
> diff --git a/drivers/net/wireless/orinoco/scan.c b/drivers/net/wireless/orinoco
> /scan.c
> index 86cb54c..e99ca1c 100644
> --- a/drivers/net/wireless/orinoco/scan.c
> +++ b/drivers/net/wireless/orinoco/scan.c
> @@ -111,6 +111,11 @@ static void orinoco_add_hostscan_result(struct orinoco_pri
> vate *priv,
>
> freq = ieee80211_dsss_chan_to_freq(le16_to_cpu(bss->a.channel));
> channel = ieee80211_get_channel(wiphy, freq);
> + if (!channel) {
> + printk(KERN_DEBUG "Invalid channel designation %04X(%04X)",
> + bss->a.channel, freq);
> + return; /* Then ignore it for now */
> + }
> timestamp = 0;
> capability = le16_to_cpu(bss->a.capabilities);
> beacon_interval = le16_to_cpu(bss->a.beacon_interv);
>
> Signed-off-by: Joseph J. Gunn <armadefuego@yahoo.com>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2011-02-25 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 10:08 [PATCH 2.6.38-rc6-wl 1/1] orinoco: Drop scan results with unknown channels Joe Gunn
2011-02-25 14:32 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225143244.GA15897@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=armadefuego@yahoo.com \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.