From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Date: Sat, 26 Feb 2011 06:41:32 +0000 Subject: Re: [PATCH v5] of/promtree: allow DT device matching by fixing Message-Id: <20110225224132.0c15eb8a@queued.net> List-Id: References: <20110224165917.3760.24493.stgit@localhost6.localdomain6> <20110224093341.5a809a13@queued.net> <20110224194234.GA8907@angua.secretlab.ca> <20110224120109.0ed9f473@queued.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Grant Likely Cc: sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, 24 Feb 2011 23:06:06 -0700 Grant Likely wrote: > On Thu, Feb 24, 2011 at 1:01 PM, Andres Salomon > wrote: > > On Thu, 24 Feb 2011 12:42:34 -0700 > > Grant Likely wrote: > >> If firmware is buggy, then pkg2path must deal with it.  It is not > >> okay for it to return NULL.  (I know that pkg2path is an OFW > >> command, but in this context it really means the linux wrapper to > >> pkg2path which has the semantics, "give me the unique, full and > >> accurate path for this node").  If OFW pkg2path doesn't work, then > >> the platform code must work around it.  I'm pushing back on this > >> because I do not want to see platform workarounds in the common > >> code. > > > > I'm fine with that, I just don't want to see BUG() happening that > > early.  I think a workaround should be handled in common code.  I > > agree that heroic workarounds for firmware bugs should be handled in > > arch-specific pkg2path hooks, but a simple workaround in common code > > is better than just crashing early in boot (imo). > > Alright, you've swayed me a bit. I've made this change and pushed it > out to devicetree/experimental. I've also picked up your other patch. > Let me know if it works for you. Thanks, that looks good. Feel free to push into next. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437Ab1BZGlh (ORCPT ); Sat, 26 Feb 2011 01:41:37 -0500 Received: from LUNGE.MIT.EDU ([18.54.1.69]:59393 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352Ab1BZGlg convert rfc822-to-8bit (ORCPT ); Sat, 26 Feb 2011 01:41:36 -0500 Date: Fri, 25 Feb 2011 22:41:32 -0800 From: Andres Salomon To: Grant Likely Cc: dsd@laptop.org, sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH v5] of/promtree: allow DT device matching by fixing 'name' brokenness Message-ID: <20110225224132.0c15eb8a@queued.net> In-Reply-To: References: <20110224165917.3760.24493.stgit@localhost6.localdomain6> <20110224093341.5a809a13@queued.net> <20110224194234.GA8907@angua.secretlab.ca> <20110224120109.0ed9f473@queued.net> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Feb 2011 23:06:06 -0700 Grant Likely wrote: > On Thu, Feb 24, 2011 at 1:01 PM, Andres Salomon > wrote: > > On Thu, 24 Feb 2011 12:42:34 -0700 > > Grant Likely wrote: > >> If firmware is buggy, then pkg2path must deal with it.  It is not > >> okay for it to return NULL.  (I know that pkg2path is an OFW > >> command, but in this context it really means the linux wrapper to > >> pkg2path which has the semantics, "give me the unique, full and > >> accurate path for this node").  If OFW pkg2path doesn't work, then > >> the platform code must work around it.  I'm pushing back on this > >> because I do not want to see platform workarounds in the common > >> code. > > > > I'm fine with that, I just don't want to see BUG() happening that > > early.  I think a workaround should be handled in common code.  I > > agree that heroic workarounds for firmware bugs should be handled in > > arch-specific pkg2path hooks, but a simple workaround in common code > > is better than just crashing early in boot (imo). > > Alright, you've swayed me a bit. I've made this change and pushed it > out to devicetree/experimental. I've also picked up your other patch. > Let me know if it works for you. Thanks, that looks good. Feel free to push into next. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Subject: Re: [PATCH v5] of/promtree: allow DT device matching by fixing 'name' brokenness Date: Fri, 25 Feb 2011 22:41:32 -0800 Message-ID: <20110225224132.0c15eb8a@queued.net> References: <20110224165917.3760.24493.stgit@localhost6.localdomain6> <20110224093341.5a809a13@queued.net> <20110224194234.GA8907@angua.secretlab.ca> <20110224120109.0ed9f473@queued.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org T24gVGh1LCAyNCBGZWIgMjAxMSAyMzowNjowNiAtMDcwMApHcmFudCBMaWtlbHkgPGdyYW50Lmxp a2VseUBzZWNyZXRsYWIuY2E+IHdyb3RlOgoKPiBPbiBUaHUsIEZlYiAyNCwgMjAxMSBhdCAxOjAx IFBNLCBBbmRyZXMgU2Fsb21vbiA8ZGlsaW5nZXJAcXVldWVkLm5ldD4KPiB3cm90ZToKPiA+IE9u IFRodSwgMjQgRmViIDIwMTEgMTI6NDI6MzQgLTA3MDAKPiA+IEdyYW50IExpa2VseSA8Z3JhbnQu bGlrZWx5QHNlY3JldGxhYi5jYT4gd3JvdGU6Cj4gPj4gSWYgZmlybXdhcmUgaXMgYnVnZ3ksIHRo ZW4gcGtnMnBhdGggbXVzdCBkZWFsIHdpdGggaXQuIMKgSXQgaXMgbm90Cj4gPj4gb2theSBmb3Ig aXQgdG8gcmV0dXJuIE5VTEwuIMKgKEkga25vdyB0aGF0IHBrZzJwYXRoIGlzIGFuIE9GVwo+ID4+ IGNvbW1hbmQsIGJ1dCBpbiB0aGlzIGNvbnRleHQgaXQgcmVhbGx5IG1lYW5zIHRoZSBsaW51eCB3 cmFwcGVyIHRvCj4gPj4gcGtnMnBhdGggd2hpY2ggaGFzIHRoZSBzZW1hbnRpY3MsICJnaXZlIG1l IHRoZSB1bmlxdWUsIGZ1bGwgYW5kCj4gPj4gYWNjdXJhdGUgcGF0aCBmb3IgdGhpcyBub2RlIiku IMKgSWYgT0ZXIHBrZzJwYXRoIGRvZXNuJ3Qgd29yaywgdGhlbgo+ID4+IHRoZSBwbGF0Zm9ybSBj b2RlIG11c3Qgd29yayBhcm91bmQgaXQuIMKgSSdtIHB1c2hpbmcgYmFjayBvbiB0aGlzCj4gPj4g YmVjYXVzZSBJIGRvIG5vdCB3YW50IHRvIHNlZSBwbGF0Zm9ybSB3b3JrYXJvdW5kcyBpbiB0aGUg Y29tbW9uCj4gPj4gY29kZS4KPiA+Cj4gPiBJJ20gZmluZSB3aXRoIHRoYXQsIEkganVzdCBkb24n dCB3YW50IHRvIHNlZSBCVUcoKSBoYXBwZW5pbmcgdGhhdAo+ID4gZWFybHkuIMKgSSB0aGluayBh IHdvcmthcm91bmQgc2hvdWxkIGJlIGhhbmRsZWQgaW4gY29tbW9uIGNvZGUuIMKgSQo+ID4gYWdy ZWUgdGhhdCBoZXJvaWMgd29ya2Fyb3VuZHMgZm9yIGZpcm13YXJlIGJ1Z3Mgc2hvdWxkIGJlIGhh bmRsZWQgaW4KPiA+IGFyY2gtc3BlY2lmaWMgcGtnMnBhdGggaG9va3MsIGJ1dCBhIHNpbXBsZSB3 b3JrYXJvdW5kIGluIGNvbW1vbiBjb2RlCj4gPiBpcyBiZXR0ZXIgdGhhbiBqdXN0IGNyYXNoaW5n IGVhcmx5IGluIGJvb3QgKGltbykuCj4gCj4gQWxyaWdodCwgeW91J3ZlIHN3YXllZCBtZSBhIGJp dC4gIEkndmUgbWFkZSB0aGlzIGNoYW5nZSBhbmQgcHVzaGVkIGl0Cj4gb3V0IHRvIGRldmljZXRy ZWUvZXhwZXJpbWVudGFsLiAgSSd2ZSBhbHNvIHBpY2tlZCB1cCB5b3VyIG90aGVyIHBhdGNoLgo+ ICBMZXQgbWUga25vdyBpZiBpdCB3b3JrcyBmb3IgeW91LgoKClRoYW5rcywgdGhhdCBsb29rcyBn b29kLiAgRmVlbCBmcmVlIHRvIHB1c2ggaW50byBuZXh0LgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxpbmcgbGlz dApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFi cy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNzCg==