All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH 1/4] e2image: Add support for qcow2 format
Date: Sat, 26 Feb 2011 11:28:26 -0500	[thread overview]
Message-ID: <20110226162826.GC2924@thunk.org> (raw)
In-Reply-To: <1298638173-25050-1-git-send-email-lczerner@redhat.com>

On Fri, Feb 25, 2011 at 01:49:30PM +0100, Lukas Czerner wrote:
> This commit adds support for exporting filesystem into QCOW2 image
> format. Like sparse format this saves space, by writing only necessary
> (metadata blocks) into image. Unlike sparse image, QCOW2 image is NOT
> sparse, hence does not change its size by copying with not-sparse-aware
> tools.
> 
> New options '-Q' has been added to tell the e2image to use QCOW2 as an
> output image format. QCOW2 supports encryption and compression, however
> e2image so far does no support such features, however you can still
> scramble filenames with '-s' option.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

I noticed that the qcow2 functions have a qcow2_ prefix and aren't
prefixed with ext2_.  That's a namespace leakage, although I
understand why adding ext2_ to functions that really have nothing to
do with ext2_ might not make sense.

What this *does* make me wonder though, is whether or not we should
split off qcow2 into its own separate library...

						- Ted

      parent reply	other threads:[~2011-02-26 16:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25 12:49 [PATCH 1/4] e2image: Add support for qcow2 format Lukas Czerner
2011-02-25 12:49 ` [PATCH 2/4] e2image: Support for conversion QCOW2 image into raw Lukas Czerner
2011-02-25 12:49 ` [PATCH 4/4] e2fsck: Add QCOW2 support Lukas Czerner
2011-02-26 16:44   ` Ted Ts'o
2011-02-28  9:44     ` Rogier Wolff
2011-03-01 11:42     ` Lukas Czerner
2011-03-07 10:40       ` Amir Goldstein
2011-03-07 12:40         ` Lukas Czerner
2011-03-09 16:30           ` Lukas Czerner
2011-03-09 17:52             ` Amir Goldstein
2011-03-17 13:05       ` Lukas Czerner
2011-02-26 16:28 ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110226162826.GC2924@thunk.org \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.