diff for duplicates of <201102262256.31565.nai.xia@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 526d413..fea2189 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,7 +4,7 @@ inaccurate. This patch add a vm_stat entry and let the /proc/meminfo show information about how much virutal address pte is being mapped to ksm pages. With default -ksm paramters (pages_to_scan=100 && sleep_millisecs=20), this can result in +ksm paramters (pages_to_scan==100 && sleep_millisecs==20), this can result in 50% more accurate averaged savings result for the following test program. Bigger sleep_millisecs values will increase this deviation. @@ -45,14 +45,14 @@ int main(int argc, char **argv) p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0); - if (p = MAP_FAILED) { + if (p == MAP_FAILED) { printf("mmap error\n"); return 0; } ret = madvise(p, SIZE, MADV_MERGEABLE); - if (ret=-1) { + if (ret==-1) { printf("madvise failed \n"); return 0; } @@ -137,7 +137,7 @@ index c2b2a94..3c22d30 100644 @@ -897,6 +897,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, */ - if (write_protect_page(vma, page, &orig_pte) = 0) { + if (write_protect_page(vma, page, &orig_pte) == 0) { if (!kpage) { + long mapcount = page_mapcount(page); /* diff --git a/a/content_digest b/N1/content_digest index 3de198b..6681deb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Nai Xia <nai.xia@gmail.com>\0" "Subject\0[PATCH] ksm: add vm_stat and meminfo entry to reflect pte mapping to ksm pages\0" - "Date\0Sat, 26 Feb 2011 14:56:31 +0000\0" + "Date\0Sat, 26 Feb 2011 22:56:31 +0800\0" "To\0Izik Eidus <ieidus@redhat.com>\0" "Cc\0Hugh Dickins <hugh.dickins@tiscali.co.uk>" Andrea Arcangeli <aarcange@redhat.com> @@ -18,7 +18,7 @@ "\n" "This patch add a vm_stat entry and let the /proc/meminfo show information \n" "about how much virutal address pte is being mapped to ksm pages. With default \n" - "ksm paramters (pages_to_scan=100 && sleep_millisecs=20), this can result in \n" + "ksm paramters (pages_to_scan==100 && sleep_millisecs==20), this can result in \n" "50% more accurate averaged savings result for the following test program. \n" "Bigger sleep_millisecs values will increase this deviation. \n" "\n" @@ -59,14 +59,14 @@ "\n" "\tp = mmap(NULL, SIZE, PROT_WRITE|PROT_READ, \n" "\t\t MAP_PRIVATE|MAP_ANONYMOUS, 0, 0);\n" - " \tif (p = MAP_FAILED) {\n" + " \tif (p == MAP_FAILED) {\n" " \t\tprintf(\"mmap error\\n\");\n" " \t\treturn 0;\n" " \t}\n" "\n" "\tret = madvise(p, SIZE, MADV_MERGEABLE);\n" "\n" - "\tif (ret=-1) {\n" + "\tif (ret==-1) {\n" "\t\tprintf(\"madvise failed \\n\");\n" "\t\treturn 0;\n" "\t}\n" @@ -151,7 +151,7 @@ "@@ -897,6 +897,7 @@ static int try_to_merge_one_page(struct vm_area_struct \n" "*vma,\n" " \t */\n" - " \tif (write_protect_page(vma, page, &orig_pte) = 0) {\n" + " \tif (write_protect_page(vma, page, &orig_pte) == 0) {\n" " \t\tif (!kpage) {\n" "+\t\t\tlong mapcount = page_mapcount(page);\n" " \t\t\t/*\n" @@ -234,4 +234,4 @@ "\n" --- -6b1cb6615d14388a22b68b778ab3e71307b31ddb73a4614470108f86e395663e +dd5bfba71b802e406ab2fea309944de0d7664b6c82c293d19a9d0cb416b155f3
diff --git a/a/1.txt b/N2/1.txt index 526d413..9e06f32 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,7 +4,7 @@ inaccurate. This patch add a vm_stat entry and let the /proc/meminfo show information about how much virutal address pte is being mapped to ksm pages. With default -ksm paramters (pages_to_scan=100 && sleep_millisecs=20), this can result in +ksm paramters (pages_to_scan==100 && sleep_millisecs==20), this can result in 50% more accurate averaged savings result for the following test program. Bigger sleep_millisecs values will increase this deviation. @@ -45,14 +45,14 @@ int main(int argc, char **argv) p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0); - if (p = MAP_FAILED) { + if (p == MAP_FAILED) { printf("mmap error\n"); return 0; } ret = madvise(p, SIZE, MADV_MERGEABLE); - if (ret=-1) { + if (ret==-1) { printf("madvise failed \n"); return 0; } @@ -137,7 +137,7 @@ index c2b2a94..3c22d30 100644 @@ -897,6 +897,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, */ - if (write_protect_page(vma, page, &orig_pte) = 0) { + if (write_protect_page(vma, page, &orig_pte) == 0) { if (!kpage) { + long mapcount = page_mapcount(page); /* @@ -219,3 +219,12 @@ index f21f4a1..0d7ab31 100644 return; --- + + + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 3de198b..f4378ce 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,6 +1,6 @@ "From\0Nai Xia <nai.xia@gmail.com>\0" "Subject\0[PATCH] ksm: add vm_stat and meminfo entry to reflect pte mapping to ksm pages\0" - "Date\0Sat, 26 Feb 2011 14:56:31 +0000\0" + "Date\0Sat, 26 Feb 2011 22:56:31 +0800\0" "To\0Izik Eidus <ieidus@redhat.com>\0" "Cc\0Hugh Dickins <hugh.dickins@tiscali.co.uk>" Andrea Arcangeli <aarcange@redhat.com> @@ -18,7 +18,7 @@ "\n" "This patch add a vm_stat entry and let the /proc/meminfo show information \n" "about how much virutal address pte is being mapped to ksm pages. With default \n" - "ksm paramters (pages_to_scan=100 && sleep_millisecs=20), this can result in \n" + "ksm paramters (pages_to_scan==100 && sleep_millisecs==20), this can result in \n" "50% more accurate averaged savings result for the following test program. \n" "Bigger sleep_millisecs values will increase this deviation. \n" "\n" @@ -59,14 +59,14 @@ "\n" "\tp = mmap(NULL, SIZE, PROT_WRITE|PROT_READ, \n" "\t\t MAP_PRIVATE|MAP_ANONYMOUS, 0, 0);\n" - " \tif (p = MAP_FAILED) {\n" + " \tif (p == MAP_FAILED) {\n" " \t\tprintf(\"mmap error\\n\");\n" " \t\treturn 0;\n" " \t}\n" "\n" "\tret = madvise(p, SIZE, MADV_MERGEABLE);\n" "\n" - "\tif (ret=-1) {\n" + "\tif (ret==-1) {\n" "\t\tprintf(\"madvise failed \\n\");\n" "\t\treturn 0;\n" "\t}\n" @@ -151,7 +151,7 @@ "@@ -897,6 +897,7 @@ static int try_to_merge_one_page(struct vm_area_struct \n" "*vma,\n" " \t */\n" - " \tif (write_protect_page(vma, page, &orig_pte) = 0) {\n" + " \tif (write_protect_page(vma, page, &orig_pte) == 0) {\n" " \t\tif (!kpage) {\n" "+\t\t\tlong mapcount = page_mapcount(page);\n" " \t\t\t/*\n" @@ -232,6 +232,15 @@ " \tif (!atomic_add_negative(-1, &page->_mapcount))\n" " \t\treturn;\n" "\n" - --- + "---\n" + "\n" + " \n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -6b1cb6615d14388a22b68b778ab3e71307b31ddb73a4614470108f86e395663e +f9e1f2e6d87a2ff4b35ae5c32449af702bb8e2d94e358dcfe5a9d4e8c4674662
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.