From: Vlad Dogaru <ddvlad@rosedu.org>
To: NetDev <netdev@vger.kernel.org>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>
Subject: [PATCH nex-next] netdevice: make initial group visible to userspace
Date: Sun, 27 Feb 2011 10:39:12 +0200 [thread overview]
Message-ID: <20110227083911.GA29638@cormyr> (raw)
In-Reply-To: <20110225124345.0d691789@nehalam>
On Fri, Feb 25, 2011 at 12:43:45PM -0800, Stephen Hemminger wrote:
> On Wed, 2 Feb 2011 20:23:40 +0200
> Vlad Dogaru <ddvlad@rosedu.org> wrote:
>
> > User can specify device group to list by using the group keyword:
> >
> > ip link show group test
> >
> > If no group is specified, 0 (default) is implied.
> >
> > Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>
>
> I applied this to net-next for iproute2
> but INIT_NETDEV_GROUP is in a part of netdevice.h that is not exported
> (ie inside #ifdef KERNEL).
Sorry, here is a patch for net-next that fixes the issue:
[PATCH net-next] netdevice: make initial group visible to userspace
INIT_NETDEV_GROUP is needed by userspace, move it outside __KERNEL__
guards.
Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>
---
include/linux/netdevice.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index ffe56c1..8be4056 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -75,9 +75,6 @@ struct wireless_dev;
#define NET_RX_SUCCESS 0 /* keep 'em coming, baby */
#define NET_RX_DROP 1 /* packet dropped */
-/* Initial net device group. All devices belong to group 0 by default. */
-#define INIT_NETDEV_GROUP 0
-
/*
* Transmit return codes: transmit return codes originate from three different
* namespaces:
@@ -141,6 +138,9 @@ static inline bool dev_xmit_complete(int rc)
#define MAX_ADDR_LEN 32 /* Largest hardware address length */
+/* Initial net device group. All devices belong to group 0 by default. */
+#define INIT_NETDEV_GROUP 0
+
#ifdef __KERNEL__
/*
* Compute the worst case header length according to the protocols
--
1.7.1
next prev parent reply other threads:[~2011-02-27 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 18:23 [PATCH v4 0/2] iproute2: support for device groups Vlad Dogaru
2011-02-02 18:23 ` [PATCH v4 1/2] iproute2: support listing devices by group Vlad Dogaru
2011-02-25 20:43 ` Stephen Hemminger
2011-02-27 8:39 ` Vlad Dogaru [this message]
2011-03-03 5:56 ` [PATCH nex-next] netdevice: make initial group visible to userspace David Miller
2011-02-02 18:23 ` [PATCH v4 2/2] iproute2: support device group semantics Vlad Dogaru
2011-02-02 23:01 ` [PATCH v4 0/2] iproute2: support for device groups Patrick McHardy
2011-02-03 0:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110227083911.GA29638@cormyr \
--to=ddvlad@rosedu.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.