From: Dan Carpenter <error27@gmail.com>
To: Alessio Igor Bogani <abogani@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Tim Bird <tim.bird@am.sony.com>
Subject: Re: [PATCH] rtlwifi: make gcc happy
Date: Mon, 28 Feb 2011 03:38:23 +0300 [thread overview]
Message-ID: <20110228003734.GA9075@bicker> (raw)
In-Reply-To: <1298841390-1194-1-git-send-email-abogani@kernel.org>
On Sun, Feb 27, 2011 at 10:16:30PM +0100, Alessio Igor Bogani wrote:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
>
These fix actual bugs where uninitialized values are used; it's not
just a matter of silencing warnings. The patch title should mention
that. Perhaps something like:
[patch] rtlwifi: fix places where uninitialized data is used
regards,
dan carpenter
next prev parent reply other threads:[~2011-02-28 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 21:16 [PATCH] rtlwifi: make gcc happy Alessio Igor Bogani
2011-02-27 21:58 ` Larry Finger
2011-02-28 0:38 ` Dan Carpenter [this message]
2011-02-28 8:11 ` [PATCH] rtlwifi: fix places where uninitialized data is used Alessio Igor Bogani
2011-02-28 18:31 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228003734.GA9075@bicker \
--to=error27@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abogani@kernel.org \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.