Re: [PATCH] ext4: Fix missing iput for root inode in case of all failed mount paths.

[Ted Ts'o <tytso@mit.edu>]

On Sat, Feb 26, 2011 at 01:35:05PM -0800, Manish Katiyar wrote:
> 
> Is there anything else that I need to do to get this merged in your tree ?
> 

I've added the patch with the following explanation:

ext4: fix missing iput of root inode for some mount error paths

This assures that the root inode is not leaked, and that sb->s_root is
NULL, which will prevent generic_shutdown_super() from doing extra
work, including call sync_filesystem, which ultimately results in
ext4_sync_fs() getting called with an uninitialized struct super,
which is the cause of the crash noted in Kernel Bugzilla #26752.

https://bugzilla.kernel.org/show_bug.cgi?id=26752

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>


Sorry for the delay, but this patch was held up pending my tracingg
through the code and understanding why this really fixed BZ #26752.
In the future, adding a bit more detail in the commit log will help me
process the patch faster, since I won't have to reproduce your
analysis.

Also, just quoting a BZ number without going into more detail risks my
putting it the patch on my "to analyze --- when I have access to
network" queue if I happen to come across it while on an airplane.  :-)

					- Ted