All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: nblocks arg to ext4_truncate_restart_trans() is ignored
Date: Sun, 27 Feb 2011 23:41:39 -0500	[thread overview]
Message-ID: <20110228044139.GP2924@thunk.org> (raw)
In-Reply-To: <AANLkTikjhsA0ooZAkS4zhaMrFidOgpjuk54cTxu30Xb5@mail.gmail.com>

On Sun, Feb 27, 2011 at 11:54:28AM +0200, Amir Goldstein wrote:
> nblocks is passed into ext4_truncate_restart_trans() from
> ext4_ext_truncate_extend_restart() with a value different from the default
> blocks_for_truncate(), but is being ignored.
> 
> The two other calls to ext4_truncate_restart_trans() already pass the
> default value, which is then being recalculated inside the function.
> 
> Fix the problem by using the passed argument.
> 
> Signed-off-by: Amir Goldstein <amir73il@users.sf.net>

Thanks, added to the ext4 patch queue.

							- Ted

      reply	other threads:[~2011-02-28 16:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-27  9:54 [PATCH] ext4: nblocks arg to ext4_truncate_restart_trans() is ignored Amir Goldstein
2011-02-28  4:41 ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110228044139.GP2924@thunk.org \
    --to=tytso@mit.edu \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.