From: Grant Likely <grant.likely@secretlab.ca>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-serial@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
nios2-dev@sopc.et.ntust.edu.tw
Subject: Re: [PATCH 5/5 v3] tty: serial: altera_jtaguart: Add device tree support
Date: Mon, 28 Feb 2011 01:26:22 -0700 [thread overview]
Message-ID: <20110228082622.GD13690@angua.secretlab.ca> (raw)
In-Reply-To: <1298016601-19111-1-git-send-email-tklauser@distanz.ch>
On Fri, Feb 18, 2011 at 09:10:01AM +0100, Tobias Klauser wrote:
> Advertise the possibility to use this driver with device tree if
> CONFIG_OF is set.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied, thanks.
g.
> ---
> v3:
> - put device tree binding documentation in the correct place (thanks Grant
> Likely)
> v2:
> - add missing semicolon after definition of altera_jtaguart_match
>
> .../devicetree/bindings/serial/altera_jtaguart.txt | 4 ++++
> drivers/tty/serial/altera_jtaguart.c | 15 +++++++++++++--
> 2 files changed, 17 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/serial/altera_jtaguart.txt
>
> diff --git a/Documentation/devicetree/bindings/serial/altera_jtaguart.txt b/Documentation/devicetree/bindings/serial/altera_jtaguart.txt
> new file mode 100644
> index 0000000..c152f65
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/altera_jtaguart.txt
> @@ -0,0 +1,4 @@
> +Altera JTAG UART
> +
> +Required properties:
> +- compatible : should be "ALTR,juart-1.0"
> diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
> index 8f014bb..60e049b 100644
> --- a/drivers/tty/serial/altera_jtaguart.c
> +++ b/drivers/tty/serial/altera_jtaguart.c
> @@ -466,12 +466,23 @@ static int __devexit altera_jtaguart_remove(struct platform_device *pdev)
> return 0;
> }
>
> +#ifdef CONFIG_OF
> +static struct of_device_id altera_jtaguart_match[] = {
> + { .compatible = "ALTR,juart-1.0", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, altera_jtaguart_match);
> +#else
> +#define altera_jtaguart_match NULL
> +#endif /* CONFIG_OF */
> +
> static struct platform_driver altera_jtaguart_platform_driver = {
> .probe = altera_jtaguart_probe,
> .remove = __devexit_p(altera_jtaguart_remove),
> .driver = {
> - .name = DRV_NAME,
> - .owner = THIS_MODULE,
> + .name = DRV_NAME,
> + .owner = THIS_MODULE,
> + .of_match_table = altera_jtaguart_match,
> },
> };
>
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2011-02-28 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 20:28 [PATCH 0/5] tty: serial: Updates for altera_jtaguart driver Tobias Klauser
2011-02-17 20:28 ` [PATCH 1/5] tty: serial: altera_jtaguart: Don't use plain integer as NULL pointer Tobias Klauser
2011-02-17 20:29 ` [PATCH 2/5] tty: serial: altera_jtaguart: Remove unused function early_altera_jtaguart_setup Tobias Klauser
2011-02-17 20:29 ` [PATCH 3/5] tty: serial: altera_jtaguart: Support getting mapbase and IRQ from resources Tobias Klauser
2011-02-17 20:29 ` [PATCH 4/5] tty: serial: altera_jtaguart: Fixup type usage of port flags Tobias Klauser
2011-02-17 20:30 ` [PATCH 5/5] tty: serial: altera_jtaguart: Add device tree support Tobias Klauser
2011-02-18 7:54 ` [PATCH 5/5 v2] " Tobias Klauser
2011-02-18 7:59 ` Grant Likely
[not found] ` <c28550ba11ed228f4137ced1ab34761c08ad38ad.1297974227.git.tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2011-02-18 8:10 ` [PATCH 5/5 v3] " Tobias Klauser
2011-02-28 8:26 ` Grant Likely [this message]
2011-02-17 22:15 ` [PATCH 0/5] tty: serial: Updates for altera_jtaguart driver Greg KH
2011-02-18 7:23 ` Tobias Klauser
2011-02-18 7:29 ` [Nios2-dev] " Thomas Chou
2011-02-18 7:45 ` Tobias Klauser
2011-02-18 8:06 ` Grant Likely
2011-02-18 8:11 ` Tobias Klauser
2011-02-18 17:20 ` Grant Likely
2011-02-18 15:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228082622.GD13690@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=nios2-dev@sopc.et.ntust.edu.tw \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.