All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/2] mc13892: reboot on wdi event
Date: Mon, 28 Feb 2011 14:37:41 +0000	[thread overview]
Message-ID: <20110228143740.GD13869@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110228132643.964403175@rtp-net.org>

On Mon, Feb 28, 2011 at 02:21:33PM +0100, Arnaud Patard wrote:

> +
> +	/* allows to reboot on wdi event */
> +	ret = mc13xxx_reg_read(mc13892, MC13892_POWERCTL2, &val);
> +	if (!ret) {
> +		val |= MC13892_POWERCTL2_WDIRESET;
> +		mc13xxx_reg_write(mc13892, MC13892_POWERCTL2, val);
> +	}
> +

Also, why is this in the regulator driver?  The MFD core for the device
might be a better choice - that'll ensure it gets done even if regulator
support isn't enabled for some reason.

  parent reply	other threads:[~2011-02-28 14:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 13:21 [patch 0/2] Get watchdog reboot working on efika smartbook Arnaud Patard (Rtp)
2011-02-28 13:21 ` [patch 1/2] mc13892: reboot on wdi event Arnaud Patard (Rtp)
2011-02-28 14:35   ` Mark Brown
2011-02-28 15:25     ` Arnaud Patard (Rtp)
2011-02-28 18:11       ` Mark Brown
2011-02-28 19:19         ` Arnaud Patard (Rtp)
2011-03-01 20:56       ` Liam Girdwood
2011-02-28 14:37   ` Mark Brown [this message]
2011-02-28 15:30     ` Arnaud Patard (Rtp)
2011-02-28 13:21 ` [patch 2/2] efika mx/sb: enable watchdog Arnaud Patard (Rtp)
2011-02-28 14:47   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110228143740.GD13869@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.