From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Enable PMB support on SH4AL-DSP
Date: Tue, 01 Mar 2011 08:06:24 +0000 [thread overview]
Message-ID: <20110301080623.GC5985@linux-sh.org> (raw)
In-Reply-To: <20110301064150.GB5985@linux-sh.org>
On Tue, Mar 01, 2011 at 05:02:17PM +0900, Magnus Damm wrote:
> On Tue, Mar 1, 2011 at 3:41 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> > On Tue, Mar 01, 2011 at 03:45:14PM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> The SH4AL-DSP core included in sh7372 requires use of the PMB,
> >> update the CONFIG_PMB Kconfig entry to reflect this.
> >>
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >
> > No. SH4AL-DSP does not in general have a PMB. If this CPU subtype is
> > special, then it needs to be special cased.
>
> Well, SH4AL-DSP may not have a PMB in general, but it also may not
> "not" have it either.
>
> This is what I can tell after going through data sheet for a bunch of
> SH4AL-DSP SoCs:
>
> sh7722 SH4AL-DSP
> sh7366 SH4AL-DSP
> sh7343 SH4AL-DSP + EXT
> sh7367 SH4AL-DSP + EXT + PMB + BOOT
> sh7377 SH4AL-DSP + EXT + PMB + BOOT
> sh7372 SH4AL-DSP + EXT + PMB + BOOT
>
> EXT = "SH4AL-DSP Extended Functions"
> PMB = "32-bit Address Extended Mode"
> BOOT = "32-bit Boot Function"
>
> From the table it looks like the SH4AL-DSP core can come with and without PMB.
>
That's a pretty special way of interpreting the results.
> How would you like to special case it?
>
From the above table we see that all SH4AL-DSPs that are standalone cores
have no PMB functionality, and that the only ones that do are in ARM/SH
multi-core configurations. This is what needs to be special cased.
Implying that the potential existence of the PMB has anything at all to
do with SH4AL-DSP outside of the SH/R-Mobile context is disingenous at
best.
If a standalone SH4AL-DSP pops up with PMB functionality in the future
then of course that can be special cased too, but for now implying that
SH4AL-DSP = PMB is absurd.
next prev parent reply other threads:[~2011-03-01 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 6:41 [PATCH] sh: Enable PMB support on SH4AL-DSP Paul Mundt
2011-03-01 6:45 ` Magnus Damm
2011-03-01 8:02 ` Magnus Damm
2011-03-01 8:06 ` Paul Mundt [this message]
2011-03-01 8:40 ` Magnus Damm
2011-03-01 9:02 ` Paul Mundt
2011-03-01 9:12 ` Magnus Damm
2011-03-01 9:25 ` Paul Mundt
2011-03-02 4:39 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301080623.GC5985@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.