diff for duplicates of <20110301120327.GA13273@localhost> diff --git a/a/1.txt b/N1/1.txt index 0387097..60cf175 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -30,7 +30,7 @@ On Tue, Mar 01, 2011 at 06:59:45AM +0100, Gerrit Renker wrote: > > I am attaching the relevant patch from the test tree - would it be possible > for you to test it with the same setup? (The relevant passage is right in -> the first hunk, where it tests for state = DCCP_CLOSED). +> the first hunk, where it tests for state == DCCP_CLOSED). As expected I do not seem able to trigger the null-pointer exception with the patch applied to 2.6.38-rc6. The patch does not apply to the @@ -55,7 +55,7 @@ Thanks, Johan -From eda93f93102ad13bc470db63cfd7b0dc27d1e4fa Mon Sep 17 00:00:00 2001 +>From eda93f93102ad13bc470db63cfd7b0dc27d1e4fa Mon Sep 17 00:00:00 2001 From: Johan Hovold <jhovold@gmail.com> Date: Tue, 1 Mar 2011 12:13:39 +0100 Subject: [PATCH] net: dccp: fix null-pointer dereference on close @@ -72,7 +72,7 @@ index e424a09..421f42c 100644 /* Caller (dccp_v4_do_rcv) will send Reset */ dcb->dccpd_reset_code = DCCP_RESET_CODE_NO_CONNECTION; return 1; -+ } else if (sk->sk_state = DCCP_CLOSED) { ++ } else if (sk->sk_state == DCCP_CLOSED) { + dcb->dccpd_reset_code = DCCP_RESET_CODE_NO_CONNECTION; + return 1; } diff --git a/a/content_digest b/N1/content_digest index 3d3384f..67cfd0a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,11 @@ "ref\020110226174505.GB3609@localhost\0" + "ref\020110301055945.GA4761@gerrit.erg.abdn.ac.uk\0" "From\0Johan Hovold <jhovold@gmail.com>\0" "Subject\0Re: dccp: null-pointer dereference on close\0" - "Date\0Tue, 01 Mar 2011 12:03:27 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Date\0Tue, 1 Mar 2011 13:03:27 +0100\0" + "To\0Gerrit Renker <gerrit@erg.abdn.ac.uk>\0" + "Cc\0dccp@vger.kernel.org" + " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "On Tue, Mar 01, 2011 at 06:59:45AM +0100, Gerrit Renker wrote:\n" @@ -37,7 +40,7 @@ "> \n" "> I am attaching the relevant patch from the test tree - would it be possible\n" "> for you to test it with the same setup? (The relevant passage is right in \n" - "> the first hunk, where it tests for state = DCCP_CLOSED).\n" + "> the first hunk, where it tests for state == DCCP_CLOSED).\n" "\n" "As expected I do not seem able to trigger the null-pointer exception\n" "with the patch applied to 2.6.38-rc6. The patch does not apply to the\n" @@ -62,7 +65,7 @@ "Johan\n" "\n" "\n" - "From eda93f93102ad13bc470db63cfd7b0dc27d1e4fa Mon Sep 17 00:00:00 2001\n" + ">From eda93f93102ad13bc470db63cfd7b0dc27d1e4fa Mon Sep 17 00:00:00 2001\n" "From: Johan Hovold <jhovold@gmail.com>\n" "Date: Tue, 1 Mar 2011 12:13:39 +0100\n" "Subject: [PATCH] net: dccp: fix null-pointer dereference on close\n" @@ -79,7 +82,7 @@ " \t\t/* Caller (dccp_v4_do_rcv) will send Reset */\n" " \t\tdcb->dccpd_reset_code = DCCP_RESET_CODE_NO_CONNECTION;\n" " \t\treturn 1;\n" - "+\t} else if (sk->sk_state = DCCP_CLOSED) {\n" + "+\t} else if (sk->sk_state == DCCP_CLOSED) {\n" "+\t\tdcb->dccpd_reset_code = DCCP_RESET_CODE_NO_CONNECTION;\n" "+\t\treturn 1;\n" " \t}\n" @@ -99,4 +102,4 @@ "-- \n" 1.7.4 -e90fd595d661fab53fb61091e40eac603abc254545d20a24bd015adc4490a4db +b63c9c9f1f46511599cb11d416738c83f364b78438bfd3840d306d2c7f6a36d9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.