From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Sheng Yang <sheng@linux.intel.com>, Avi Kivity <avi@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 3/4] KVM: Emulate MSI-X table in kernel
Date: Tue, 1 Mar 2011 17:18:58 -0300 [thread overview]
Message-ID: <20110301201858.GA8368@amt.cnet> (raw)
In-Reply-To: <20110225082938.GB17290@redhat.com>
On Fri, Feb 25, 2011 at 10:29:38AM +0200, Michael S. Tsirkin wrote:
> On Fri, Feb 25, 2011 at 02:28:02PM +0800, Sheng Yang wrote:
> > On Thursday 24 February 2011 18:45:08 Michael S. Tsirkin wrote:
> > > On Thu, Feb 24, 2011 at 05:51:04PM +0800, Sheng Yang wrote:
> > > > Then we can support mask bit operation of assigned devices now.
> > > >
> > > > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> > >
> > > Doesn't look like all comments got addressed.
> > > E.g. gpa_t entry_base is still there and in reality
> > > you said it's a host virtual address so
> > > should be void __user *;
> >
> > Would update it.
> >
> > > And ENOTSYNC meaning 'MSIX' is pretty hacky.
> >
> > I'd like to discuss it later. We may need some work on all MMIO handling side to
> > make it more straightforward. But I don't want to bundle it with this one...
>
> It's not PCI related so I'll defer to Avi/Marcelo on this.
> Are you guys happy with the ENOTSYNC meaning 'MSIX'
What would be a better alternative to ENOTSYNC? Can't see any.
> and userspace_exit_needed hacks in this code?
I thought this was handled by mmio_needed in a previous patch?
Since x86_emulate_instruction does
} else if (vcpu->mmio_needed) {
if (vcpu->mmio_is_write)
vcpu->mmio_needed = 0;
r = EMULATE_DO_MMIO;
It should be fine. Sheng why did you introduce userspace_exit_needed?
next prev parent reply other threads:[~2011-03-01 20:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 9:51 [PATCH 0/4 v10] MSI-X MMIO support for KVM Sheng Yang
2011-02-24 9:51 ` [PATCH 1/4] KVM: Move struct kvm_io_device to kvm_host.h Sheng Yang
2011-02-24 9:51 ` [PATCH 2/4] KVM: Add kvm_io_ext_data to IO handler Sheng Yang
2011-02-24 10:22 ` Michael S. Tsirkin
2011-02-25 3:23 ` Sheng Yang
2011-02-25 8:12 ` Michael S. Tsirkin
2011-02-28 5:13 ` Sheng Yang
2011-02-24 9:51 ` [PATCH 3/4] KVM: Emulate MSI-X table in kernel Sheng Yang
2011-02-24 10:45 ` Michael S. Tsirkin
2011-02-25 6:28 ` Sheng Yang
2011-02-25 8:29 ` Michael S. Tsirkin
2011-02-28 5:18 ` Sheng Yang
2011-03-01 20:18 ` Marcelo Tosatti [this message]
2011-03-01 20:59 ` Michael S. Tsirkin
2011-03-02 1:23 ` Sheng Yang
2011-02-25 6:50 ` Sheng Yang
2011-02-25 6:50 ` [PATCH 3/4 v10 UPDATED] " Sheng Yang
2011-02-24 9:51 ` [PATCH 4/4] KVM: Add documents for MSI-X MMIO API Sheng Yang
-- strict thread matches above, loose matches on Subject: below --
2011-03-02 7:26 [PATCH 0/4 v12] MSI-X MMIO support for KVM Sheng Yang
2011-03-02 7:26 ` [PATCH 3/4] KVM: Emulate MSI-X table in kernel Sheng Yang
2011-02-28 7:20 [PATCH 0/4 v11] MSI-X MMIO support for KVM Sheng Yang
2011-02-28 7:20 ` [PATCH 3/4] KVM: Emulate MSI-X table in kernel Sheng Yang
2011-02-28 11:27 ` Michael S. Tsirkin
2011-03-01 6:10 ` Sheng Yang
2011-03-01 12:20 ` Michael S. Tsirkin
2011-03-01 12:37 ` Sheng Yang
2011-03-01 13:01 ` Sheng Yang
2011-02-18 8:53 [PATCH 0/4 v9] MSI-X MMIO support for KVM Sheng Yang
2011-02-18 8:53 ` [PATCH 3/4] KVM: Emulate MSI-X table in kernel Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301201858.GA8368@amt.cnet \
--to=mtosatti@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.