From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757606Ab1CBAR1 (ORCPT ); Tue, 1 Mar 2011 19:17:27 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:41294 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757485Ab1CBARZ (ORCPT ); Tue, 1 Mar 2011 19:17:25 -0500 From: "Rafael J. Wysocki" To: Sarah Sharp Subject: Re: 2.6.38 regression caused by commit 415e12b Date: Wed, 2 Mar 2011 01:17:04 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.38-rc6+; KDE/4.4.4; x86_64; ; ) Cc: linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jesse Barnes , Ozan Caglayan References: <20110228014218.GA11083@xanatos> <201103020030.16494.rjw@sisk.pl> <20110302000445.GA2621@xanatos> In-Reply-To: <20110302000445.GA2621@xanatos> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Message-Id: <201103020117.04251.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, March 02, 2011, Sarah Sharp wrote: > On Wed, Mar 02, 2011 at 12:30:16AM +0100, Rafael J. Wysocki wrote: > > On Tuesday, March 01, 2011, Sarah Sharp wrote: > > > On Tue, Mar 01, 2011 at 09:55:33PM +0100, Rafael J. Wysocki wrote: > > > > Please check if the appended patch (on top of the Linus' current) helps. > > > > > > Sorry, it doesn't help. Same message as before. > > > > Can you send dmesg with the patch applied, please? > > Attached. Something's fishy. Evidently, _OSC is not executed on your system although it should be with the patch. Please try the patch below instead and send dmesg (either way). Thanks, Rafael --- drivers/acpi/pci_root.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) Index: linux-2.6/drivers/acpi/pci_root.c =================================================================== --- linux-2.6.orig/drivers/acpi/pci_root.c +++ linux-2.6/drivers/acpi/pci_root.c @@ -48,10 +48,7 @@ static int acpi_pci_root_add(struct acpi static int acpi_pci_root_remove(struct acpi_device *device, int type); static int acpi_pci_root_start(struct acpi_device *device); -#define ACPI_PCIE_REQ_SUPPORT (OSC_EXT_PCI_CONFIG_SUPPORT \ - | OSC_ACTIVE_STATE_PWR_SUPPORT \ - | OSC_CLOCK_PWR_CAPABILITY_SUPPORT \ - | OSC_MSI_SUPPORT) +#define ACPI_PCIE_REQ_SUPPORT (OSC_EXT_PCI_CONFIG_SUPPORT | OSC_MSI_SUPPORT) static const struct acpi_device_id root_device_ids[] = { {"PNP0A03", 0}, @@ -572,8 +569,10 @@ static int __devinit acpi_pci_root_add(s if (flags != base_flags) acpi_pci_osc_support(root, flags); - if (!pcie_ports_disabled - && (flags & ACPI_PCIE_REQ_SUPPORT) == ACPI_PCIE_REQ_SUPPORT) { + if (!pcie_ports_disabled) { + dev_info(root->bus->bridge, + "ACPI _OSC support set (0x%02x)\n", flags); + flags = OSC_PCI_EXPRESS_CAP_STRUCTURE_CONTROL | OSC_PCI_EXPRESS_NATIVE_HP_CONTROL | OSC_PCI_EXPRESS_PME_CONTROL;