From: Andrea Arcangeli <aarcange@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <jweiner@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] remove compaction from kswapd
Date: Wed, 2 Mar 2011 18:21:41 +0100 [thread overview]
Message-ID: <20110302172141.GF23911@random.random> (raw)
In-Reply-To: <20110301215759.f723c9bc.akpm@linux-foundation.org>
On Tue, Mar 01, 2011 at 09:57:59PM -0800, Andrew Morton wrote:
> On Wed, 2 Mar 2011 06:52:21 +0100 Andrea Arcangeli <aarcange@redhat.com> wrote:
>
> > These are the other two patches that are needed for both workloads to
> > be better than before.
> >
> > mm-compaction-minimise-the-time-irqs-are-disabled-while-isolating-pages-for-migration
> > mm-compaction-minimise-the-time-irqs-are-disabled-while-isolating-free-pages
>
> I have those queued for 2.6.39 - they didn't seem terribly critical and
> no mention of NMI watchdog timeouts was made.
>
> Guys, this stuff matters :( Should both go into 2.6.38? If so, why?
Ok: before commit 5a03b051ed87e72b959f32a86054e1142ac4cf55 it was
unnoticeable problem (the above two patches are fixing longstanding
bugs). But the combination of kswapd running compaction in a loop
after commit 5a03b051ed87e72b959f32a86054e1142ac4cf55, and compaction
keeping irqs disabled for too long (longstanding bug, but unnoticed
before 5a03b051ed87e72b959f32a86054e1142ac4cf55), shows both
problems. If you have a single problem you don't notice so much the
other one. But kswapd calling compaction in a loop, and compaction
keeping irqs disabled for too long are separate problems that shows
each other.
I think we want the above two patches and the patch Mel sent with
Message-ID: <20110302142542.GE14162@csn.ul.ie> in 2.6.38.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-02 17:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 22:21 [PATCH] remove compaction from kswapd Andrea Arcangeli
2011-03-01 22:33 ` Minchan Kim
2011-03-01 22:39 ` Andrea Arcangeli
2011-03-01 23:10 ` Minchan Kim
2011-03-02 0:41 ` Andrew Morton
2011-03-02 4:38 ` Andrea Arcangeli
2011-03-02 4:39 ` Andrea Arcangeli
2011-03-02 4:53 ` Andrew Morton
2011-03-02 5:52 ` Andrea Arcangeli
2011-03-02 5:57 ` Andrew Morton
2011-03-02 17:21 ` Andrea Arcangeli [this message]
2011-03-02 14:25 ` Mel Gorman
2011-03-09 22:17 ` Andrew Morton
2011-03-09 23:50 ` Andrea Arcangeli
2011-03-10 10:11 ` Mel Gorman
2011-03-09 17:00 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302172141.GF23911@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jweiner@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.