From: Greg KH <greg@kroah.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, arnaud.patard@rtp-net.org
Subject: Re: [RFC PATCH] staging: xgifb: remove private ioctls
Date: Wed, 2 Mar 2011 16:01:27 -0500 [thread overview]
Message-ID: <20110302210127.GA20522@kroah.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1103021931550.3526@loser>
On Wed, Mar 02, 2011 at 08:19:11PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Wed, 2 Mar 2011, Greg KH wrote:
> >On Tue, Mar 01, 2011 at 11:50:12PM +0200, Aaro Koskinen wrote:
> >>Drop the badly defined and broken private ioctl interface. Since the
> >>driver is in staging, and some of the ioctls are clearly unsafe or not
> >>even working, it's unlikely that there are any users.
> >>
> >>Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> >
> >Is this just a RFC, or do you want me to apply this patch?
>
> I wasn't sure if we should try to retain all the interfaces the driver
> provides. But if there are no objections, please apply, it will help a
> lot with further cleanups.
Ok, care to resend it without the RFC then?
thanks,
greg k-h
prev parent reply other threads:[~2011-03-02 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 21:50 [RFC PATCH] staging: xgifb: remove private ioctls Aaro Koskinen
2011-03-02 15:31 ` Greg KH
2011-03-02 18:19 ` Aaro Koskinen
2011-03-02 21:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302210127.GA20522@kroah.com \
--to=greg@kroah.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.