From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 1/1] PRUSS UIO driver support
Date: Thu, 3 Mar 2011 19:15:55 +0100 [thread overview]
Message-ID: <201103031915.55825.arnd@arndb.de> (raw)
In-Reply-To: <1299175677-17859-2-git-send-email-pratheesh@ti.com>
On Thursday 03 March 2011 19:07:57 Pratheesh Gangadhar wrote:
> +struct uio_pruss_dev {
> + struct uio_info *info;
> + struct clk *pruss_clk;
> + dma_addr_t sram_paddr;
> + dma_addr_t ddr_paddr;
> + void __iomem *prussio_vaddr;
> + void *sram_vaddr;
> + void *ddr_vaddr;
> + unsigned int hostirq_start;
> + unsigned int pintc_base;
> +};
> +
> +struct pruss_priv {
> + struct uio_pruss_dev *pupdev;
> +};
I cannot see the point of struct pruss_priv, I think it would be better to
just merge the two data structures into one. Everything else looks
good to me now.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Pratheesh Gangadhar <pratheesh@ti.com>
Cc: linux-kernel@vger.kernel.org, hjk@hansjkoch.de, gregkh@suse.de,
tglx@linutronix.de, sshtylyov@mvista.com, amit.chatterjee@ti.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 1/1] PRUSS UIO driver support
Date: Thu, 3 Mar 2011 19:15:55 +0100 [thread overview]
Message-ID: <201103031915.55825.arnd@arndb.de> (raw)
In-Reply-To: <1299175677-17859-2-git-send-email-pratheesh@ti.com>
On Thursday 03 March 2011 19:07:57 Pratheesh Gangadhar wrote:
> +struct uio_pruss_dev {
> + struct uio_info *info;
> + struct clk *pruss_clk;
> + dma_addr_t sram_paddr;
> + dma_addr_t ddr_paddr;
> + void __iomem *prussio_vaddr;
> + void *sram_vaddr;
> + void *ddr_vaddr;
> + unsigned int hostirq_start;
> + unsigned int pintc_base;
> +};
> +
> +struct pruss_priv {
> + struct uio_pruss_dev *pupdev;
> +};
I cannot see the point of struct pruss_priv, I think it would be better to
just merge the two data structures into one. Everything else looks
good to me now.
Arnd
next prev parent reply other threads:[~2011-03-03 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 18:07 [PATCH v9 0/1] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-03-03 18:07 ` Pratheesh Gangadhar
2011-03-03 18:07 ` [PATCH v9 1/1] " Pratheesh Gangadhar
2011-03-03 18:07 ` Pratheesh Gangadhar
2011-03-03 18:15 ` Arnd Bergmann [this message]
2011-03-03 18:15 ` Arnd Bergmann
2011-03-04 3:25 ` TK, Pratheesh Gangadhar
2011-03-04 3:25 ` TK, Pratheesh Gangadhar
2011-03-08 10:34 ` Thomas Gleixner
2011-03-08 10:34 ` Thomas Gleixner
2011-03-08 13:24 ` Arnd Bergmann
2011-03-08 13:24 ` Arnd Bergmann
2011-03-08 15:01 ` Thomas Gleixner
2011-03-08 15:01 ` Thomas Gleixner
2011-03-04 4:40 ` TK, Pratheesh Gangadhar
2011-03-04 4:40 ` TK, Pratheesh Gangadhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103031915.55825.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.