From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] st_nlink after rmdir() and rename()
Date: Thu, 3 Mar 2011 21:30:16 +0000 [thread overview]
Message-ID: <20110303213016.GP22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AANLkTinJPQtcBQsBd+OmioywcxSgzWXFgqMBSrfx8e6D@mail.gmail.com>
On Thu, Mar 03, 2011 at 01:02:50PM -0800, Linus Torvalds wrote:
> > So we have to simulate some levels. I guess you
> > are not saying we don't need to care it at all though.
>
> I'm saying that it should just work to set i_nlink=1 and not do
> anything at all. Ever. It's a valid model for directory counts.
Sure, no problem. Just leave that cleaning of i_nlink on victim
in unlink/rmdir/rename; we *really* rely on that in e.g. deciding
when to free the damn inode in fat_evict_inode().
We need to mark them for freeing _anyway_, right? It doesn't depend
on what exact value do we keep for live directories - "everyone got 1
for as long as they live" is just fine, and IMO it's a win, but it's
an unrelated question.
next prev parent reply other threads:[~2011-03-03 21:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 3:24 [RFC] st_nlink after rmdir() and rename() Al Viro
2011-03-03 4:42 ` Al Viro
2011-03-03 5:17 ` Linus Torvalds
2011-03-03 6:03 ` Al Viro
2011-03-03 20:05 ` Linus Torvalds
2011-03-03 20:05 ` Linus Torvalds
2011-03-03 20:46 ` OGAWA Hirofumi
2011-03-03 20:50 ` OGAWA Hirofumi
2011-03-03 21:02 ` Linus Torvalds
2011-03-03 21:30 ` Al Viro [this message]
2011-03-03 21:37 ` OGAWA Hirofumi
2011-03-03 21:52 ` Linus Torvalds
2011-03-03 22:26 ` OGAWA Hirofumi
2011-03-03 22:37 ` Linus Torvalds
2011-03-03 23:14 ` OGAWA Hirofumi
2011-03-03 23:12 ` Al Viro
2011-03-03 22:57 ` Al Viro
2011-03-03 23:07 ` Al Viro
2011-03-04 6:55 ` omfs fixes Al Viro
2011-03-04 15:24 ` Bob Copeland
2011-03-03 21:23 ` [RFC] st_nlink after rmdir() and rename() Al Viro
2011-03-03 14:34 ` Theodore Tso
2011-03-03 16:17 ` Andreas Schwab
2011-03-03 19:16 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303213016.GP22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.