From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms Date: Fri, 4 Mar 2011 04:29:56 +0300 Message-ID: <20110304012956.GA13573@ioremap.net> References: <4D6F6180.5030903@trash.net> <20110303173230.GP4988@sequoia.sous-sol.org> <20110303.105655.189705829.davem@davemloft.net> <20110303201522.GT4988@sequoia.sous-sol.org> <20110303223746.GI25069@barkeeper1-xen.linbit> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit> Sender: linux-security-module-owner@vger.kernel.org To: Chris Wright , David Miller , linux-fbdev@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dm-devel@redhat.com List-Id: dm-devel.ids Hi. On Thu, Mar 03, 2011 at 11:37:46PM +0100, Lars Ellenberg (lars.ellenberg@linbit.com) wrote: > If so, then this change introduces the possibility for normal users to > send privileged commands to connector based subsystems, even if they > may not be able to bind() to suitable sockets to receive any replies. > > Am I missing something? Yup, connector is very async at that place, but I wonder why the hell I ever made that decision. I believe we can replace it with pure sync call of the registered connector callback, since netlink is synchronous and no one has any problem with it. -- Evgeniy Polyakov From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Date: Fri, 04 Mar 2011 01:29:56 +0000 Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct Message-Id: <20110304012956.GA13573@ioremap.net> List-Id: References: <4D6F6180.5030903@trash.net> <20110303173230.GP4988@sequoia.sous-sol.org> <20110303.105655.189705829.davem@davemloft.net> <20110303201522.GT4988@sequoia.sous-sol.org> <20110303223746.GI25069@barkeeper1-xen.linbit> In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chris Wright , David Miller , linux-fbdev@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dm-devel@redhat.com Hi. On Thu, Mar 03, 2011 at 11:37:46PM +0100, Lars Ellenberg (lars.ellenberg@linbit.com) wrote: > If so, then this change introduces the possibility for normal users to > send privileged commands to connector based subsystems, even if they > may not be able to bind() to suitable sockets to receive any replies. > > Am I missing something? Yup, connector is very async at that place, but I wonder why the hell I ever made that decision. I believe we can replace it with pure sync call of the registered connector callback, since netlink is synchronous and no one has any problem with it. -- Evgeniy Polyakov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from soda.linbit (unknown [10.9.9.55]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 6A46510571D7 for ; Fri, 4 Mar 2011 16:05:56 +0100 (CET) Resent-Message-ID: <20110304150556.GG8218@barkeeper1-xen.linbit> Received: from tservice.net.ru (unknown [195.178.208.66]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 626D710571A0 for ; Fri, 4 Mar 2011 02:41:15 +0100 (CET) Date: Fri, 4 Mar 2011 04:29:56 +0300 From: Evgeniy Polyakov To: Chris Wright , David Miller , linux-fbdev@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dm-devel@redhat.com, kaber@trash.net, drbd-dev@lists.linbit.com Message-ID: <20110304012956.GA13573@ioremap.net> References: <4D6F6180.5030903@trash.net> <20110303173230.GP4988@sequoia.sous-sol.org> <20110303.105655.189705829.davem@davemloft.net> <20110303201522.GT4988@sequoia.sous-sol.org> <20110303223746.GI25069@barkeeper1-xen.linbit> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit> Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi. On Thu, Mar 03, 2011 at 11:37:46PM +0100, Lars Ellenberg (lars.ellenberg@linbit.com) wrote: > If so, then this change introduces the possibility for normal users to > send privileged commands to connector based subsystems, even if they > may not be able to bind() to suitable sockets to receive any replies. > > Am I missing something? Yup, connector is very async at that place, but I wonder why the hell I ever made that decision. I believe we can replace it with pure sync call of the registered connector callback, since netlink is synchronous and no one has any problem with it. -- Evgeniy Polyakov