From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v11 6/8] dmtimer: switch-over to platform device driver Date: Fri, 4 Mar 2011 11:37:06 -0800 Message-ID: <20110304193706.GF20560@atomide.com> References: <1298546811-27055-1-git-send-email-tarun.kanti@ti.com> <1298546811-27055-7-git-send-email-tarun.kanti@ti.com> <20110304172320.GY20560@atomide.com> <5A47E75E594F054BAF48C5E4FC4B92AB037A3605AB@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:48923 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759792Ab1CDThJ (ORCPT ); Fri, 4 Mar 2011 14:37:09 -0500 Content-Disposition: inline In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB037A3605AB@dbde02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "DebBarma, Tarun Kanti" Cc: "linux-omap@vger.kernel.org" * DebBarma, Tarun Kanti [110304 10:50]: > > -----Original Message----- > > From: Tony Lindgren [mailto:tony@atomide.com] > > Sent: Friday, March 04, 2011 10:53 PM > > To: DebBarma, Tarun Kanti > > Cc: linux-omap@vger.kernel.org > > Subject: Re: [PATCH v11 6/8] dmtimer: switch-over to platform device > > driver > > > > * Tarun Kanti DebBarma [110224 03:23]: > > > --- a/arch/arm/mach-omap2/dmtimer.c > > > +++ b/arch/arm/mach-omap2/dmtimer.c > > > @@ -197,3 +197,64 @@ static int __init omap_timer_init(struct omap_hwmod > > *oh, void *unused) > > > > > > return ret; > > > } > > > + > > > +/** > > > + * omap2_dm_timer_early_init - top level early timer initialization > > > + * called in the last part of omap2_init_common_hw > > > + * > > > + * Uses dedicated hwmod api to parse through hwmod database for > > > + * given class name and then build and register the timer device. > > > + * At the end driver is registered and early probe initiated. > > > + */ > > > +void __init omap2_dm_timer_early_init(void) > > > +{ > > > + int ret = omap_hwmod_for_each_by_class("timer", > > > + omap_timer_init, NULL); > > > > Here we really only want to initialize the system timer. The rest we > > want to do later, so let's not init all of them early. > So, that is how it was at the beginning. > Later we realized different platforms can use different timers for this. > For example, beagle uses GPT12. Therefore, as part of one of the comments, > We decided to provide flexibility so that any of the timers could be used. You can still do it, just register the one that's being used and mark it reserved so it won't get initialized again later on. Tony