From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
linux-nfs@vger.kernel.org,
Trond Myklebust <Trond.Myklebust@netapp.com>,
security@kernel.org
Subject: Re: [Security] [PATCH] nfs4: Ensure that ACL pages sent over NFS were not allocated from the slab
Date: Fri, 4 Mar 2011 16:04:14 -0500 [thread overview]
Message-ID: <20110304210414.GD21260@fieldses.org> (raw)
In-Reply-To: <20110304153059.79374df7-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
On Fri, Mar 04, 2011 at 03:30:59PM -0500, Jeff Layton wrote:
> On Fri, 4 Mar 2011 15:07:03 -0500
> "J. Bruce Fields" <bfields@fieldses.org> wrote:
> > In this case, we're not kfree()'ing until we've gotten an rpc reply
> > back. But in theory perhaps there could be cases where the server's
> > gotten the data and we've seen the reply but the tcp layer still thinks
> > it needs to retransmit something? I don't think we'd care if the data
> > was still correct in that case, but it could be an information leak if
> > nothing else.
>
> There's also timeouts + soft mounts to consider. We may send the data
> on the socket, which gets buffered up and then the caller goes to sleep
> waiting for a reply. If that never comes (server crashed or something),
> then we can return an error back up to the VFS layer if it's a soft
> mount. Meanwhile, the kernel is still trying to send the data on the
> socket...
Good point, I forgot about that.
Thanks to everyone for setting me straight!
--b.
next prev parent reply other threads:[~2011-03-04 21:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 16:44 [PATCH] nfs4: Ensure that ACL pages sent over NFS were not allocated from the slab Neil Horman
2011-03-04 16:58 ` Christoph Hellwig
2011-03-04 16:58 ` Christoph Hellwig
2011-03-04 17:13 ` J. Bruce Fields
2011-03-04 18:45 ` Neil Horman
2011-03-04 19:33 ` J. Bruce Fields
2011-03-04 19:48 ` [Security] " Linus Torvalds
2011-03-04 20:07 ` J. Bruce Fields
2011-03-04 20:30 ` Jeff Layton
2011-03-04 20:40 ` Trond Myklebust
[not found] ` <20110304153059.79374df7-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-03-04 21:04 ` J. Bruce Fields [this message]
2011-03-04 19:01 ` Trond Myklebust
2011-03-04 19:17 ` Neil Horman
2011-03-04 19:25 ` Trond Myklebust
2011-03-04 19:59 ` Neil Horman
2011-03-04 21:09 ` [PATCH] nfs4: Ensure that ACL pages sent over NFS were not allocated from the slab (v2) Neil Horman
2011-03-04 21:25 ` Trond Myklebust
2011-03-05 0:26 ` [PATCH] nfs4: Ensure that ACL pages sent over NFS were not allocated from the slab (v3) Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304210414.GD21260@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.