From: Oliver Neukum <oliver@neukum.org>
To: Florian Mickler <florian@mickler.org>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <greg@kroah.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Maciej Rutecki <maciej.rutecki@gmail.com>
Subject: Re: [PATCH] [media] dib0700: get rid of on-stack dma buffers
Date: Sun, 6 Mar 2011 13:06:09 +0100 [thread overview]
Message-ID: <201103061306.10045.oliver@neukum.org> (raw)
In-Reply-To: <1299410212-24897-1-git-send-email-florian@mickler.org>
Am Sonntag, 6. März 2011, 12:16:52 schrieb Florian Mickler:
> This should fix warnings seen by some:
> WARNING: at lib/dma-debug.c:866 check_for_stack
>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
> Reported-by: Zdenek Kabelac <zdenek.kabelac@gmail.com>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> CC: Mauro Carvalho Chehab <mchehab@infradead.org>
> CC: linux-media@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Greg Kroah-Hartman <greg@kroah.com>
> CC: Rafael J. Wysocki <rjw@sisk.pl>
> CC: Maciej Rutecki <maciej.rutecki@gmail.com>
> ---
>
> Please take a look at it, as I do not do that much kernel hacking
> and don't wanna brake anybodys computer... :)
>
> From my point of view this should _not_ go to stable even though it would
> be applicable. But if someone feels strongly about that and can
> take responsibility for that change...
The patch looks good and is needed in stable.
It could be improved by using a buffer allocated once in the places
you hold a mutex anyway.
Regards
Oliver
next prev parent reply other threads:[~2011-03-06 12:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 11:16 [PATCH] [media] dib0700: get rid of on-stack dma buffers Florian Mickler
2011-03-06 12:06 ` Oliver Neukum [this message]
2011-03-06 14:38 ` Florian Mickler
2011-03-06 14:45 ` [PATCH 1/3 v2] " Florian Mickler
2011-03-06 14:45 ` [PATCH 2/3] [media] dib0700: remove unused variable Florian Mickler
2011-03-06 14:45 ` [PATCH 3/3] [media] dib0700: don't ignore errors in driver probe Florian Mickler
2011-03-06 15:06 ` [PATCH] [media] dib0700: get rid of on-stack dma buffers Oliver Neukum
2011-03-06 15:45 ` Florian Mickler
2011-03-06 16:44 ` Oliver Neukum
2011-03-06 17:47 ` [PATCH 1/2 v3] " Florian Mickler
2011-03-06 17:47 ` [PATCH 2/2] [media] dib0700: remove unused variable Florian Mickler
2011-03-06 17:57 ` [PATCH 1/2 v3] [media] dib0700: get rid of on-stack dma buffers Florian Mickler
2011-03-15 8:36 ` Florian Mickler
2011-03-15 8:43 ` [PATCH 01/16] " Florian Mickler
2011-03-15 8:43 ` [PATCH 02/16] [media] dib0700: remove unused variable Florian Mickler
2011-03-15 8:43 ` [PATCH 03/16] [media] a800: get rid of on-stack dma buffers Florian Mickler
2011-03-15 8:43 ` [PATCH 04/16] [media] vp7045: " Florian Mickler
2011-03-15 8:43 ` [PATCH 05/16] [media] ec168: get rid of on stack " Florian Mickler
2011-03-18 16:36 ` Antti Palosaari
2011-03-18 21:33 ` Florian Mickler
2011-03-15 8:43 ` [PATCH 06/16] [media] ce6230: get rid of on-stack dma buffer Florian Mickler
2011-03-18 16:36 ` Antti Palosaari
2011-03-18 21:28 ` Florian Mickler
2011-03-15 8:43 ` [PATCH 07/16] [media] friio: get rid of on-stack dma buffers Florian Mickler
2011-03-15 8:43 ` [PATCH 11/16] [media] lmedm04: correct indentation Florian Mickler
2011-03-15 8:43 ` [PATCH 12/16] [media] lmedm04: get rid of on-stack dma buffers Florian Mickler
2011-03-15 20:54 ` Malcolm Priestley
2011-03-15 21:46 ` Florian Mickler
2011-03-15 12:02 ` [PATCH 01/16] [media] dib0700: " Mauro Carvalho Chehab
2011-03-15 21:14 ` Florian Mickler
[not found] ` <1300178655-24832-9-git-send-email-florian@mickler.org>
2011-03-18 16:34 ` [PATCH 09/16] [media] au6610: get rid of on-stack dma buffer Antti Palosaari
2011-03-18 21:27 ` Florian Mickler
2011-03-18 21:40 ` Antti Palosaari
2011-03-15 11:37 ` [PATCH 1/2 v3] [media] dib0700: get rid of on-stack dma buffers Mauro Carvalho Chehab
2011-03-06 13:49 ` [PATCH] " Jack Stone
2011-03-06 14:00 ` Florian Mickler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103061306.10045.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=florian@mickler.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mchehab@infradead.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.