All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: remi.denis-courmont@nokia.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/8] Phonet: fix backlog callback return value
Date: Mon, 07 Mar 2011 12:23:29 -0800 (PST)	[thread overview]
Message-ID: <20110307.122329.39193888.davem@davemloft.net> (raw)
In-Reply-To: <1299232831-3132-3-git-send-email-remi.denis-courmont@nokia.com>


More verbose commit message please.

What was wrong with the old error values and what exactly do
you claim to be doing to correct them?

If all I get is single header line as a commit message, you're not
doing due dilligence and you're making your work harder to
review and understand for other people.

  reply	other threads:[~2011-03-07 20:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 11:22 net-next-2.6: Phonet pull request Rémi Denis-Courmont
2011-03-03 19:03 ` David Miller
2011-03-04 10:00 ` [PATCH 1/8] Phonet: fix NULL-deref in previous patch series Rémi Denis-Courmont
2011-03-07 20:23   ` David Miller
2011-03-07 20:33     ` Rémi Denis-Courmont
2011-03-04 10:00 ` [PATCH 2/8] Phonet: return an error when TX fails Rémi Denis-Courmont
2011-03-04 10:00 ` [PATCH 3/8] Phonet: fix backlog callback return value Rémi Denis-Courmont
2011-03-07 20:23   ` David Miller [this message]
2011-03-07 20:30     ` Rémi Denis-Courmont
2011-03-07 20:31       ` David Miller
2011-03-04 10:00 ` [PATCH 4/8] Phonet: factor common code to send control messages Rémi Denis-Courmont
2011-03-04 10:00 ` [PATCH 5/8] Phonet: allocate sock from accept syscall rather than soft IRQ Rémi Denis-Courmont
2011-03-04 10:00 ` [PATCH 6/8] Phonet: provide pipe socket option to retrieve the pipe identifier Rémi Denis-Courmont
2011-03-04 10:00 ` [PATCH 7/8] Phonet: support active connection without pipe controller on modem Rémi Denis-Courmont
2011-03-04 10:00 ` [PATCH 8/8] Phonet: kill the ST-Ericsson pipe controller Kconfig Rémi Denis-Courmont
  -- strict thread matches above, loose matches on Subject: below --
2011-03-07 10:45 [RFC] [PATCH 0/8] net-next: Phonet fixes and cleanup Rémi Denis-Courmont
2011-03-07 10:46 ` [PATCH 3/8] Phonet: fix backlog callback return value Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110307.122329.39193888.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=remi.denis-courmont@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.