All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: "xenomai@xenomai.org" <xenomai@xenomai.org>,
	Jan Kiszka <jan.kiszka@domain.hid>
Subject: Re: [Xenomai-help] Stuck MSI in normal Linux driver
Date: Mon, 7 Mar 2011 10:26:04 +0100	[thread overview]
Message-ID: <20110307092604.GA21619@domain.hid> (raw)
In-Reply-To: <1299225060.2107.20.camel@domain.hid>

On Fri, Mar 04, 2011 at 08:51:00AM +0100, Philippe Gerum wrote:
> I'm not saying this would be impossible to enable MSIs there, I'm just
> saying that so far: nobody cared. Terrae incognitae.

Philippe,

I read adeos-ipipe-2.6.36-powerpc-2.12-02.patch in order to
re-acquaint myself with adeos. While I do not pretend to really
understand it, I did notice an incongruity in the interrupt handling
for my particular board.

The function, fsl_msi_cascade, in arch/powerpc/sysdev/fsl_msi.c:185
has in the non-ipipe version two different actions

	desc->chip->unmask(irq);
	desc->chip->eoi(irq);

depending on whether the controller is an ipic or mpic. The ipipe
code unconditionally executes ipic/unmask.

I noticed that the function 

	cpm_cascade() in arch/powerpc/platforms/8xx/m8xx_setup.c

does call eoi(), so I guessed that the eoi() in fsl_msi_cascade()
might have been overlooked. Putting the eoi() into the ipipe version
lets the machine handle the interrupts, and my test programs will even
run with the PCIe card and driver.

However, I am really making a grab in the dark, and I see strange
warnings like unexpected (in_irq() || irqs_disabled()) from
kernel/softirq.c:143 and so on.

Also, more interrupts appear for my card in /proc/interrupts than
expected.

Is this any kind of hint, or am I just completely lost?

Thanks,

Richard



  parent reply	other threads:[~2011-03-07  9:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 15:16 [Xenomai-help] Stuck MSI in normal Linux driver Richard Cochran
2011-03-02 15:26 ` Gilles Chanteperdrix
2011-03-02 15:34   ` Richard Cochran
2011-03-02 15:38     ` Gilles Chanteperdrix
2011-03-02 18:18   ` Jan Kiszka
2011-03-03  7:21     ` Richard Cochran
2011-03-03  7:32       ` Philippe Gerum
2011-03-03 12:25         ` Wolfgang Grandegger
2011-03-03 12:30           ` Jan Kiszka
2011-03-03 12:54             ` Philippe Gerum
2011-03-03 23:45               ` Jan Kiszka
2011-03-04  7:51                 ` Philippe Gerum
2011-03-04  8:09                   ` Jan Kiszka
2011-03-04  8:30                     ` Richard Cochran
2011-03-04  8:36                       ` Jan Kiszka
2011-03-04  8:11                   ` Richard Cochran
2011-03-04  8:16                     ` Jan Kiszka
2011-03-07  9:26                   ` Richard Cochran [this message]
2011-03-07 16:37                     ` Philippe Gerum
2011-03-07 18:33                       ` Richard Cochran
2011-03-08  7:55                         ` Richard Cochran
2011-03-07 18:39                       ` Gilles Chanteperdrix
2011-03-07 21:47                         ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110307092604.GA21619@domain.hid \
    --to=richardcochran@domain.hid \
    --cc=jan.kiszka@domain.hid \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.