From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support Date: Mon, 7 Mar 2011 15:52:26 +0100 Message-ID: <201103071552.26766.arnd@arndb.de> References: <1299503160-9910-1-git-send-email-jason.hui@linaro.org> <201103071537.49026.arnd@arndb.de> <20110307144621.GB9978@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110307144621.GB9978-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Shawn Guo Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Jason Liu , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday 07 March 2011, Shawn Guo wrote: > > Alternatively, it could be done the other way round: rename the identifiers > > in the file from mx51_ to mx5_, and make sure that they don't contain > > any mx51 specific settings but always refer to properties in the > > device tree for the differences. > > > So our ultimate goal is to have only one board-dt.c in one mach-xxx? I wouldn't make that a strict rule, but I'd say that one goal should be to have as few board-dt files as possible without adding complexity. As a start, we can say we want one file for per set of machines that can run a common binary kernel, but there may be good reasons for deviating from that rule on both sides. Arnd