From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH] KVM: unbreak userspace that does not sets tss address
Date: Mon, 7 Mar 2011 18:20:30 +0200 [thread overview]
Message-ID: <20110307162030.GB22987@redhat.com> (raw)
In-Reply-To: <4D74FE88.9060708@siemens.com>
On Mon, Mar 07, 2011 at 04:49:28PM +0100, Jan Kiszka wrote:
> On 2011-03-07 16:19, Gleb Natapov wrote:
> > Commit 6440e5967bc broke old userspaces that do not set tss address
> > before entering vcpu. Unbreak it by setting tss address to a safe
> > value on the first vcpu entry. New userspaces should set tss address,
> > so print warning in case it doesn't.
>
> Wouldn't allow runtime warnings but wouldn't it be cleaner otherwise to
> start vcpus with a default tss address like that, ie. add the logic to
> vmx_create_vcpu?
>
Userspace can create VCPU before setting tss address. We will have to
have logic that removes default tss slot in set_tss_address callback.
Also this default slot may prevent userspace from creating another slot
at this physical address which is perfectly legitimate thing for userspace
to do.
--
Gleb.
next prev parent reply other threads:[~2011-03-07 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 15:19 [PATCH] KVM: unbreak userspace that does not sets tss address Gleb Natapov
2011-03-07 15:49 ` Jan Kiszka
2011-03-07 16:20 ` Gleb Natapov [this message]
2011-03-07 16:23 ` Jan Kiszka
2011-03-07 16:26 ` Gleb Natapov
2011-03-11 17:30 ` Marcelo Tosatti
2011-03-11 18:22 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307162030.GB22987@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.