From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57193 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwjvH-0007xs-Iw for qemu-devel@nongnu.org; Mon, 07 Mar 2011 18:33:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwjvG-0008DP-FF for qemu-devel@nongnu.org; Mon, 07 Mar 2011 18:33:07 -0500 Received: from [88.191.126.93] (port=36903 helo=hall.aurel32.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwjvG-0008DJ-7j for qemu-devel@nongnu.org; Mon, 07 Mar 2011 18:33:06 -0500 Date: Tue, 8 Mar 2011 00:33:05 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH v5 07/10] softfloat: Drop [u]int32 types in favor of [u]int_fast32_t Message-ID: <20110307233305.GD10422@hall.aurel32.net> References: <1294169951-5153-5-git-send-email-andreas.faerber@web.de> <1299458053-69428-1-git-send-email-andreas.faerber@web.de> <1299458053-69428-2-git-send-email-andreas.faerber@web.de> <1299458053-69428-3-git-send-email-andreas.faerber@web.de> <1299458053-69428-4-git-send-email-andreas.faerber@web.de> <1299458053-69428-5-git-send-email-andreas.faerber@web.de> <1299458053-69428-6-git-send-email-andreas.faerber@web.de> <1299458053-69428-7-git-send-email-andreas.faerber@web.de> <20110307095625.GA6294@hall.aurel32.net> <9EBE6B5A-7D1B-4F31-A8A1-34397344DECB@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9EBE6B5A-7D1B-4F31-A8A1-34397344DECB@web.de> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-15?Q?F=E4rber?= Cc: Peter Maydell , qemu-devel@nongnu.org On Tue, Mar 08, 2011 at 12:16:49AM +0100, Andreas Färber wrote: > Am 07.03.2011 um 10:56 schrieb Aurelien Jarno: > > >On Mon, Mar 07, 2011 at 01:34:10AM +0100, Andreas Färber wrote: > >>v5: > >>* Initial. > >> > >>Cc: Peter Maydell > >>Signed-off-by: Andreas Färber > >>--- > >>fpu/softfloat.c | 132 ++++++++++++++++++++++++++ > >>+--------------------------- > >>fpu/softfloat.h | 34 +++++++-------- > >>2 files changed, 82 insertions(+), 84 deletions(-) > > >>diff --git a/fpu/softfloat.h b/fpu/softfloat.h > >>index c599cc2..4c64d77 100644 > >>--- a/fpu/softfloat.h > >>+++ b/fpu/softfloat.h > > >>@@ -394,10 +392,10 @@ INLINE float32 float32_set_sign(float32 a, > >>int sign) > >>*----------------------------------------------------------------------------*/ > >>int_fast16_t float64_to_int16_round_to_zero( float64 STATUS_PARAM ); > >>uint_fast16_t float64_to_uint16_round_to_zero( float64 > >>STATUS_PARAM ); > >>-int32 float64_to_int32( float64 STATUS_PARAM ); > >>-int32 float64_to_int32_round_to_zero( float64 STATUS_PARAM ); > >>-uint32 float64_to_uint32( float64 STATUS_PARAM ); > >>-uint32 float64_to_uint32_round_to_zero( float64 STATUS_PARAM ); > >>+int_fast32_t float64_to_int32( float64 STATUS_PARAM ); > >>+int_fast32_t float64_to_int32_round_to_zero( float64 STATUS_PARAM ); > >>+uint_fast32_t float64_to_uint32( float64 STATUS_PARAM ); > >>+uint_fast32_t float64_to_uint32_round_to_zero( float64 > >>STATUS_PARAM ); > > > >If you do such a change in the declaration, you should do the same in > >the code, otherwise it doesn't compile... > > Hrm, are you saying this is missing in 08/10, or would you like to > see that squashed into this one? > It did compile at some point, at least before I reordered patches. > You should not break bisect, so if you change the declaration in a patch, you should also change the corresponding code in the same patch. My guess is that you are using a 32-bit system, so int_fast32_t is the same size as a int. On my system int_fast32_t is equivalent to int64_t so it doesn't compile. That's why I don't think it's a good idea to use fast types. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net