From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] FC: cifs: Initialized an uninitialized variable Date: Tue, 8 Mar 2011 04:26:02 +0000 Message-ID: <20110308042601.GX22723@ZenIV.linux.org.uk> References: <1299556809-16194-1-git-send-email-vinaysawal@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vinay Sawal Return-path: Content-Disposition: inline In-Reply-To: <1299556809-16194-1-git-send-email-vinaysawal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Mon, Mar 07, 2011 at 08:00:09PM -0800, Vinay Sawal wrote: > Removed a compile time warning by initializing an uninitialized variable. > - int rc; > + int rc = -EFAULT; Why is that the right thing to do? Other than "it made the compiler to STFU, therefore it is Good(tm)", please. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756221Ab1CHE0H (ORCPT ); Mon, 7 Mar 2011 23:26:07 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:38319 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754358Ab1CHE0F (ORCPT ); Mon, 7 Mar 2011 23:26:05 -0500 Date: Tue, 8 Mar 2011 04:26:02 +0000 From: Al Viro To: Vinay Sawal Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FC: cifs: Initialized an uninitialized variable Message-ID: <20110308042601.GX22723@ZenIV.linux.org.uk> References: <1299556809-16194-1-git-send-email-vinaysawal@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1299556809-16194-1-git-send-email-vinaysawal@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 07, 2011 at 08:00:09PM -0800, Vinay Sawal wrote: > Removed a compile time warning by initializing an uninitialized variable. > - int rc; > + int rc = -EFAULT; Why is that the right thing to do? Other than "it made the compiler to STFU, therefore it is Good(tm)", please.