All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Nussbaum <lucas.nussbaum@loria.fr>
To: netdev@vger.kernel.org
Cc: Sangtae Ha <sha2@ncsu.edu>
Subject: [PATCH] tcp_cubic: enable TCP timestamps
Date: Tue, 8 Mar 2011 09:09:26 +0100	[thread overview]
Message-ID: <20110308080926.GA22641@xanadu.blop.info> (raw)

The Hystart slow start algorithm requires precise RTT delay measurements
to decide when to leave slow start. However, currently, CUBIC doesn't
enable TCP timestamps. This can cause Hystart to mis-estimate the RTT,
and to leave slow start too early, generating bad performance since
convergence to the optimal cwnd is slower.

Timestamps are already used by TCP Illinois, LP, Vegas, Veno and Yeah.

Signed-off-by: Lucas Nussbaum <lucas.nussbaum@loria.fr>

-- 
| Lucas Nussbaum             MCF Université Nancy 2 |
| lucas.nussbaum@loria.fr         LORIA / AlGorille |
| http://www.loria.fr/~lnussbau/  +33 3 54 95 86 19 |

diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c
index 71d5f2f..3a73509 100644
--- a/net/ipv4/tcp_cubic.c
+++ b/net/ipv4/tcp_cubic.c
@@ -406,6 +406,7 @@ static void bictcp_acked(struct sock *sk, u32 cnt, s32 rtt_us)
 }
 
 static struct tcp_congestion_ops cubictcp = {
+       .flags          = TCP_CONG_RTT_STAMP,
        .init           = bictcp_init,
        .ssthresh       = bictcp_recalc_ssthresh,
        .cong_avoid     = bictcp_cong_avoid,

             reply	other threads:[~2011-03-08  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08  8:09 Lucas Nussbaum [this message]
2011-03-08 18:42 ` [PATCH] tcp_cubic: enable TCP timestamps Stephen Hemminger
2011-03-08 18:55   ` David Miller
2011-03-08 19:15     ` Sangtae Ha
2011-03-08 19:36       ` Lucas Nussbaum
2011-03-08 19:38         ` David Miller
2011-03-08 19:17     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110308080926.GA22641@xanadu.blop.info \
    --to=lucas.nussbaum@loria.fr \
    --cc=netdev@vger.kernel.org \
    --cc=sha2@ncsu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.