All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: "Richard Nauber" <richard.nauber@googlemail.com>,
	linux-input <linux-input@vger.kernel.org>,
	"Jiri Kosina" <jkosina@suse.cz>,
	"Stéphane Chatty" <chatty@enac.fr>
Subject: Re: [PATCH v2] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework.
Date: Tue, 8 Mar 2011 10:46:30 +0100	[thread overview]
Message-ID: <20110308094630.GA3396@polaris.bitmath.org> (raw)
In-Reply-To: <AANLkTiko_mKgW6fXeAuBY4D5AT_9OHAJnk_mfQEPQVF9@mail.gmail.com>

> >> I'm not in favor of a quirk in this particular case: the information
> >> is already here: max > 0.
> >
> > Only if min == 0, which is far from always the case. And setting a
> > special value for a special hardware does what a quirk does, so maybe
> > it is a quirk after all.
> >
> 
> I think there is a misunderstanding:
> if the class provides max_x (so > 0), or min_x, that means that the
> person in charge of adding the driver wants to replace the two values
> min/max.

What I meant is that (min_x < max_x) is the proper test.

> No need for a quirk that will be redundant with the hand-provided values.

Yes, but I think we might be better off using a quirk than a generic
way to replace the values provided by the hardware.

Thanks,
Henrik

  reply	other threads:[~2011-03-08  9:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-06 13:25 [PATCH] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework Richard Nauber
2011-03-07 10:07 ` Benjamin Tissoires
2011-03-08  6:08   ` [PATCH v2] " Richard Nauber
2011-03-08  8:04     ` Henrik Rydberg
2011-03-08  8:55       ` Benjamin Tissoires
2011-03-08  9:14         ` Henrik Rydberg
2011-03-08  9:23           ` Benjamin Tissoires
2011-03-08  9:46             ` Henrik Rydberg [this message]
2011-03-08 23:38               ` [PATCH v3] " Richard Nauber
2011-03-09  8:24                 ` Henrik Rydberg
2011-03-09  8:54                   ` Benjamin Tissoires
2011-03-09  9:23                     ` Henrik Rydberg
2011-03-09 10:06                       ` Benjamin Tissoires
2011-03-09 11:40                         ` Henrik Rydberg
2011-03-11  6:02                           ` Richard Nauber
2011-03-11  6:53                             ` Benjamin Tissoires
2011-03-11  9:23                               ` Richard Nauber
2011-03-11  9:52                                 ` Benjamin Tissoires
2011-03-11 11:31                                   ` Henrik Rydberg
2011-03-14 12:06                             ` Jiri Kosina
2011-03-08 13:12 ` [PATCH] " Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110308094630.GA3396@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@gmail.com \
    --cc=chatty@enac.fr \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=richard.nauber@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.