From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 8 Mar 2011 15:36:46 +0100 Subject: [Buildroot] lockfile-progs depends on liblockfile In-Reply-To: References: Message-ID: <20110308153646.047f791a@surf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Alexander, On Tue, 8 Mar 2011 16:22:57 +0200 Alexander Yohananov wrote: > --- a/lockfile-progs.mk 2011-03-08 15:40:51.145037713 +0200 > +++ b/lockfile-progs.mk 2011-03-08 15:39:35.032038246 +0200 > @@ -11,6 +11,8 @@ > $(addprefix lockfile-,check create remove touch) \ > $(addprefix mail-,lock touchlock unlock) > > +LOCKFILE_PROGS_DEPENDENCIES = liblockfile > + > define LOCKFILE_PROGS_BUILD_CMDS > $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) > endef Correct. lockfile-progs already selects the liblockfile package in its Config.in file, but does not depend on it in its .mk file, which is wrong. Your fix is correct. > The other possible fix is to add liblockfile to dependencies list in > usbmount.mk: > USBMOUNT_DEPENDENCIES = udev lockfile-progs liblockfile (I don't know > whether the order is important) No, that wouldn't work. By doing so, you wouldn't have the guarantee that liblockfile is built before lockfile-progs, so the compilation of the latter could still fail. > The problem exists on buildroot-2010.11, but since buildroot-2011.02 > contains exactly the same usbmount, lockfile-progs and liblockfile it > apparently will appear there as well. Yes, this issue hasn't been fixed in the latest version. Do you want to send a proper patch so we can keep your attribution, or do you want me to send a patch, mentioning your name ? Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com