From: Arnd Bergmann <arnd@arndb.de>
To: Andrei Warkentin <andreiw@motorola.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
tardyp@gmail.com, linux-mmc@vger.kernel.org
Subject: Re: [[RFC] 2/5] MMC: Add block quirks support.
Date: Tue, 8 Mar 2011 17:21:58 +0100 [thread overview]
Message-ID: <201103081721.58633.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTi=DhG+yBESfGdFrc7gox2Z_VW-rOfhezsVyeitO@mail.gmail.com>
On Monday 07 March 2011, Andrei Warkentin wrote:
>
> I took a look at quirks.c in linux-next. It's a bit sdio-specific... I
> would extend mmc_fixup to contain card type (to know if cis
> vendor/device should be checked) as well as name/manfid/oemid and rev
> id (which is just a combination of hwrev, fwrev and date).
Makes sense.
> Vendor_fixup would be the top-level card fixup.
> I would add blk_fixup (so block specific information like desired
> write align size can be kept inside mmc_blk_data instead of polluting
> mmc_card).
>
> ...and to support part reliability workarounds for Toshiba cards, will
> add a blk_adjust method to be invoked inside blk req handling.
>
> Arnd, what do you think?
I'm still not comfortable with having the blk_adjust method. I think it
would be much better to encode that behavior in an abstract way in
the block driver and set a flag to enable it in the quirks file.
Arnd
next prev parent reply other threads:[~2011-03-08 16:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 22:09 MMC block quirk support + Toshiba performance quirk Andrei Warkentin
2011-03-01 22:09 ` [RFC 1/3] MMC: Adjust unaligned write accesses Andrei Warkentin
2011-03-01 22:09 ` [RFC 2/3] MMC: Add block quirks support Andrei Warkentin
2011-03-02 17:19 ` Arnd Bergmann
2011-03-02 20:48 ` Andrei Warkentin
2011-03-02 21:04 ` Arnd Bergmann
2011-03-02 21:19 ` Andrei Warkentin
2011-03-01 22:09 ` [RFC 3/3] MMC: Toshiba eMMC - Split 8K-unaligned accesses Andrei Warkentin
2011-03-05 3:21 ` MMC block quirk support + Toshiba quirks Andrei Warkentin
2011-03-05 3:21 ` [[RFC] 1/5] MMC: Adjust unaligned write accesses Andrei Warkentin
2011-03-05 3:21 ` [[RFC] 2/5] MMC: Add block quirks support Andrei Warkentin
2011-03-05 3:21 ` [[RFC] 3/5] MMC: Toshiba eMMC - Split 8K-unaligned accesses Andrei Warkentin
2011-03-05 3:21 ` [[RFC] 4/5] MMC: Block quirks request adjust support Andrei Warkentin
2011-03-05 3:21 ` [[RFC] 5/5] MMC: Toshiba eMMC - Part reliability improvement Andrei Warkentin
2011-03-06 12:28 ` [[RFC] 2/5] MMC: Add block quirks support Linus Walleij
2011-03-06 21:20 ` Linus Walleij
2011-03-07 8:16 ` Andrei Warkentin
2011-03-07 20:39 ` Andrei Warkentin
2011-03-07 20:51 ` Andrei Warkentin
2011-03-08 20:28 ` Linus Walleij
2011-03-08 20:34 ` Andrei Warkentin
2011-03-08 20:57 ` Andrei Warkentin
2011-03-08 10:37 ` Tardy, Pierre
2011-03-08 16:21 ` Arnd Bergmann [this message]
[not found] ` <201103081542.46831.arnd@arndb.de>
2011-03-08 20:27 ` Andrei Warkentin
2011-03-13 13:48 ` MMC " Andrei Warkentin
2011-03-13 13:48 ` [PATCH 1/2] MMC: Extends card quicks with MMC/SD quirks matching the CID Andrei Warkentin
2011-03-13 14:55 ` Arnd Bergmann
2011-04-11 20:55 ` Chris Ball
2011-04-11 21:25 ` Andrei Warkentin
2011-04-11 22:02 ` [PATCH] " Andrei Warkentin
2011-04-11 21:50 ` Chris Ball
2011-04-11 21:47 ` Andrei Warkentin
2011-03-13 13:48 ` [PATCH 2/2] MMC: Support for block quirks Andrei Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103081721.58633.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andreiw@motorola.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tardyp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.