From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Fix prefixing of DAPM controls by factoring prefix into snd_soc_cnew()
Date: Wed, 9 Mar 2011 11:03:14 +0000 [thread overview]
Message-ID: <20110309110314.GF6923@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110309101951.18c804f5.jhnikula@gmail.com>
On Wed, Mar 09, 2011 at 10:19:51AM +0200, Jarkko Nikula wrote:
> Unfortunately this leads to double prefixing to mixer and mux controls
> on Nokia RX-51/N900 in today's head. Reason there is that the
> snd_soc_dapm_new_control has already added the prefix to widget name
> and the dapm_new_mixer/mux takes this prefixed w->name and prefixes it
> again.
The system I'm using isn't affected as there's no unnamed mixers in it.
I rather suspect this means that the old code is broken for named
mixers. Working on a fix just now.
next prev parent reply other threads:[~2011-03-09 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 17:25 [PATCH] ASoC: Fix prefixing of DAPM controls by factoring prefix into snd_soc_cnew() Mark Brown
2011-03-08 18:01 ` Liam Girdwood
2011-03-09 8:19 ` Jarkko Nikula
2011-03-09 11:03 ` Mark Brown [this message]
2011-03-09 11:35 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309110314.GF6923@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.