From: Jarkko Nikula <jhnikula@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Fix double addition of prefixes due to widget prefixing
Date: Wed, 9 Mar 2011 13:47:48 +0200 [thread overview]
Message-ID: <20110309134748.014ab0fd.jhnikula@gmail.com> (raw)
In-Reply-To: <1299670452-13290-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, 9 Mar 2011 11:34:12 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> We're not only prefixing all controls, we're also prefixing the widget
> names in the runtime data. This causes us to add the prefix twice - once
> when using the widget name to generate the control name and once when
> adding the control.
>
> Really we shouldn't be prefixing the widget names at all, the matching
> code should be handing this as we always know which DAPM context a
> widget came from and always display the widget name in terms of a DAPM
> context. However, we're quite close to the merge window and that's
> relatively invasive.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-dapm.c | 29 ++++++++++++++++++++++++++---
> 1 files changed, 26 insertions(+), 3 deletions(-)
>
No problem anymore on N900.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2011-03-09 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 11:34 [PATCH] ASoC: Fix double addition of prefixes due to widget prefixing Mark Brown
2011-03-09 11:47 ` Jarkko Nikula [this message]
2011-03-09 11:56 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309134748.014ab0fd.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.