All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu,
	linux-kernel@vger.kernel.org, phan@redhat.com
Subject: Re: [PATCH 1/2] perf,top: fix events overflow in top command
Date: Wed, 9 Mar 2011 11:25:56 -0300	[thread overview]
Message-ID: <20110309142556.GC20188@ghostprotocols.net> (raw)
In-Reply-To: <20110309141910.GB1929@jolsa.brq.redhat.com>

Em Wed, Mar 09, 2011 at 03:19:10PM +0100, Jiri Olsa escreveu:
> On Wed, Mar 09, 2011 at 11:06:10AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Mar 09, 2011 at 10:59:25AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Good catch, applying to perf/urgent.
> > 
> > Tried but it doesn't apply nor can I reproduce the overflow (albeit
> > granted the long line of events is annoying).
> 
> patches were based on tip tree
> 
> hm, it crashes for me on tip tree,
> but I haven't checked the perf/core tree..
> 
> not sure if it's any help, but while debugging I could see the sigsegv happened
> when the pointer was far beyond the 160 chars buffer size,
> maybe the buffer got bigger in the perf tree..

Anyway, using tip/master you are using perf/core so the patch was made
against it, I already merged it, will be on my next pull request to
Ingo.

Thanks,

- Arnaldo

  reply	other threads:[~2011-03-09 14:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 20:13 [PATCH 0/2] perf: fix events overflow in top command Jiri Olsa
2011-03-07 20:13 ` [PATCH 1/2] perf,top: " Jiri Olsa
2011-03-09 13:59   ` Arnaldo Carvalho de Melo
2011-03-09 14:06     ` Arnaldo Carvalho de Melo
2011-03-09 14:19       ` Jiri Olsa
2011-03-09 14:25         ` Arnaldo Carvalho de Melo [this message]
2011-03-11  9:46   ` [tip:perf/core] perf top: Fix " tip-bot for Jiri Olsa
2011-03-07 20:13 ` [PATCH 2/2] perf,top: dont let events to eat up whole header line Jiri Olsa
2011-03-11  9:47   ` [tip:perf/core] perf top: Don't " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110309142556.GC20188@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=phan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.